Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[todo] Investigate whether we should turn on NETKET_EXPERIMENTAL_FFT_AUTOCORRELATION by default #1560

Open
PhilipVinc opened this issue Aug 5, 2023 · 0 comments
Labels
contributor welcome We welcome contributions or PRs on this issue enhancement New feature or request help wanted Extra attention is needed

Comments

@PhilipVinc
Copy link
Member

setting NETKET_EXPERIMENTAL_FFT_AUTOCORRELATION=1 makes sure that we use a proper autocorrelation time calculation based on FFT to estimate the autocorrelation time in the chains.

This is a bit more expensive that the naive algorithm for estimating the autocorrelation time that is used by default, which is sometimes wrong.

We never looked into how much more expensive NETKET_EXPERIMENTAL_FFT_AUTOCORRELATION is and whether we can switch.
I personally would prefer to switch over to more correct results, even if it comes at a small cost. but this should be benchmarked...

If someone wants to investigate this:

  • we should benchmark how expensive it is to estimate expectation values with and without this flag (it can be turned on and off by doing nk.config.netket_experimental_fft_autocorrelation = True/False ) for very simple observables, for different number of samples.
  • see how much performance is lost.
@PhilipVinc PhilipVinc added enhancement New feature or request help wanted Extra attention is needed contributor welcome We welcome contributions or PRs on this issue labels Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor welcome We welcome contributions or PRs on this issue enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant