Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import schedule interprets 12:30 as 12:30 am instead of 12:30 pm #442

Open
montereyjeff opened this issue Mar 10, 2023 · 5 comments
Open
Assignees
Labels
bug Something isn't working
Projects

Comments

@montereyjeff
Copy link

After importing this YAML content:

  • show-title: 'The Cultural Frontline'
    show-schedule: { Saturday: [['12:30', '13:00']] }
    show-active: 'on'

The schedule showed the time range as 12:30 am to 1:00 pm instead of 12:30 pm to 1:00 pm.

Copy link
Member

Thanks for reporting this. An external developer created this feature and I'll have to contact him to ask him to fix this issue. We'll let you know when it can be resolved.

@tonyzeoli tonyzeoli added the bug Something isn't working label Mar 10, 2023
@tonyzeoli
Copy link
Member

@voyager131 if you have some time to look at this and update the code, that would be helpful. Thanks.

@montereyjeff
Copy link
Author

I did some further testing. Using these times:

  • show-title: 'The Cultural Frontline'
    show-schedule: { Saturday: [['00:30', '01:00']] }
    show-active: 'on'

which showed up this way in the schedule column of the list of shows:
Saturday :30am - 1:00am

but when I open the show itself and look at the Show Schedule, it says 1:30 am to 1:00 am.

The 00 hour should be 12 am and the 12 hour (in 24-hour format) should be 12 pm.

@montereyjeff
Copy link
Author

And still more testing...

  1. If the "Delete existing show data" box is checked on import, this warning appears:
    Warning: _() expects exactly 1 parameter, 2 given in /home/customer/www/kspb.org/public_html/wp-content/plugins/radio-station-pro-premium/includes/rsp-import-export.php on line 1330

  2. The import interpreted 10:00 (in 24-hour format) as 1:00 am

  3. Can you add export and import support for show-genre?

  4. Empty images are created in the site Media Library when a show does not have every possible image file. For example, if a show has a show-avatar but not a show-image or show-header, then two empty image files with random names are added to the Media Library in addition to the avatar image file.

@tonyzeoli
Copy link
Member

tonyzeoli commented Mar 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Backlog
Awaiting triage
Development

No branches or pull requests

3 participants