Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a resource usage problem in the WebSocket08FrameDecoder #2441

Closed
normanmaurer opened this issue Apr 30, 2014 · 0 comments
Closed

Fix a resource usage problem in the WebSocket08FrameDecoder #2441

normanmaurer opened this issue Apr 30, 2014 · 0 comments
Milestone
4.0.19.Final

Comments

@normanmaurer
Copy link
Member

Before we aggregated the full text in the WebSocket08FrameDecoder just to fill in the ContinuationWebSocketFrame.aggregatedText(). The problem was that there was no upper-limit and so it would be possible to see an OOME if the remote peer sends a TextWebSocketFrame + a never ending stream of ContinuationWebSocketFrames. Furthermore the aggregation does not really belong in the WebSocket08FrameDecoder, as we provide an extra ChannelHandler for this anyway (WebSocketFrameAggregator).

See also CVE-2014-0193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.19.Final
Development

No branches or pull requests
1 participant
@normanmaurer