Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform output of ecg_quality algorithms #959

Open
LucaCerina opened this issue Jan 29, 2024 · 0 comments
Open

Uniform output of ecg_quality algorithms #959

LucaCerina opened this issue Jan 29, 2024 · 0 comments

Comments

@LucaCerina
Copy link
Contributor

Describe the bug
Currently the Zhao2018 algorithm in ecg_quality() function returns a string of the quality class, while others return a number. This behaviour complicates pipelines where the quality algorithm may be interchangeable.

To Reproduce
Behaviour always happening since it's a design choice.

Expected behaviour
Best case scenario is that all ecg_quality() returned a metric factor (e.g. a score, that can be also discretized, from 0 to 100). Otherwise it's better if it returns a number by default (with proper documentation on the meaning) and only optionally the string.

Screenshots
None applicable

System Specifications
Independent of system specifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant