Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReleasePR workflow failing for v0.2.8 #984

Closed
EvanCesanek opened this issue Apr 16, 2024 · 4 comments
Closed

ReleasePR workflow failing for v0.2.8 #984

EvanCesanek opened this issue Apr 16, 2024 · 4 comments

Comments

@EvanCesanek
Copy link

EvanCesanek commented Apr 16, 2024

Perhaps you are already aware of this, but the latest release v0.2.8 is not deploying to PyPI, so it cannot be installed using pip install.

See Actions -> Workflows -> ReleasePR -> Merge pull request #926 from neuropsychology/dev -> Build and publish Python 🐍 distributions 📦 to PyPI and TestPyPI

Apologies for not resolving this myself, but I am not really set up to test this workflow.

[Edited: I originally misunderstood the source of the problem and suggested a fix that wouldn't resolve it. See my next comment for the actual problem and a proposed solution.]

Thank you!

Copy link

welcome bot commented Apr 16, 2024

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

@DerAndereJohannes
Copy link
Contributor

It would be great to get this fixed, i'm guessing that only a maintainer can realistically make and test these changes, right?

@EvanCesanek
Copy link
Author

EvanCesanek commented Apr 25, 2024

Thanks @DerAndereJohannes! I agree. I also looked back at this quickly and realized my thoughts above about the source of this failure were incorrect. Examining the ReleasePR workflow logs from the two Attempts reveals the actual issue:

Attempt 1 successfully deployed to Test PyPI: https://test.pypi.org/project/neurokit2/0.2.8/
However, the next step failed, when deploying to regular PyPI with the following error:

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         User 'DominiqueMakowski' does not have a verified primary email        
         address. Please add a verified primary email before attempting to      
         upload to PyPI. See https://pypi.org/help/#verified-email for more     
         information.

Unfortunately, even if the verified primary email problem is fixed, we will get a new error on retrying the ReleasePR workflow (see Attempt 2). This is due to the fact that 0.2.8 was successfully deployed to TestPyPI in Attempt 1.

ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information.

So it looks like two things must be done: (1) the verified primary email problem must be corrected and then (2) a modified version of the ReleasePR workflow must be run that skips the "Publish distribution to TestPyPI" step.

@DominiqueMakowski DominiqueMakowski mentioned this issue May 21, 2024
13 tasks
@DominiqueMakowski
Copy link
Member

Should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants