Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMX: handle commented lines #273

Open
varas opened this issue Aug 3, 2021 · 0 comments
Open

JMX: handle commented lines #273

varas opened this issue Aug 3, 2021 · 0 comments
Labels
logging triage/in-progress Issue or PR is in the process of being triaged.

Comments

@varas
Copy link
Contributor

varas commented Aug 3, 2021

Description

JMX server endpoint may return "Java comment" lines like # An error report file with more information is saved as:.

In this case JMX will return an error like error: invalid character '#' looking for beginning of value.

It'd be great to handle this case properly and log this as a warning.

Ideally an integration execution instance should be able to keep fetching the rest of the requested data/queries defined.

Nice to haves

  1. A JMX server error may report several lines. Current jmx package is limited to read just 1 line.
    It'd be great to get the whole error message logged as a single entry.

  2. Circuit breaker. Whenever several queries fail in a row (in this case we are handling "java comment" lines, but this could be extrapolated to other errors), the jmx package client (let's call it that way, although API is a set of awful global functions sharing global state) should prevent next queries to be submitted and log an error instead. This will avoid worsening the JMX endpoint scenario, as it already returned N errors in a row.

@davidgit davidgit added the triage/in-progress Issue or PR is in the process of being triaged. label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging triage/in-progress Issue or PR is in the process of being triaged.
Projects
None yet
Development

No branches or pull requests

2 participants