Fix/remove versions from examples #2195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
nextcloud#2194 Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
|
Mentioning #2201. Which provides a more robust solution than this simple fix. The real conversation is happening there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2194
I think this PR is necessary because without this change users are shown a warning:
WARN[0000] docker-compose.yml: 'version' is obsolete.From my perspective, many self-hosters are not experts in Docker and often use it as a way to make setting up services easier. The provided example documents are valuable to these users for this reason.
Having warnings show in the terminal or console when running docker compose commands might affect how users think and feel about the software that they are running. From my perspective, these types of users seem to expect an out-of-the-box working set up with example files like these.
For that reason, instead of running in loose mode, I recommend simply removing the version name from the example yamls.