Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening NC right menu from richdocuments is not possible if the user does not have sharing permission #3334

Open
maximelehericy opened this issue Dec 1, 2023 · 1 comment
Labels
1. to develop Waiting for a developer enhancement New feature or request feature: share link

Comments

@maximelehericy
Copy link

Describe the bug
Usually in Collabora, the following icons are shown at the top right of the editor.
image

The following one allows to open the sharing tab of the nextcloud files, and from the sharing tab, you can access the details, or the comments, or the chat and video tab, which is quite useful if you want to comment or have a call at the same time you edit the document.
image

Howewer, this icon is not present if the user cannot share the file. But even if the user cannot share the file, he might want to comment it, or have a call.
image

To Reproduce
Steps to reproduce the behavior:

  1. Create a folder (or a groupfolder) and an office document inside the folder
  2. Share this folder with Alice, and remove the reshare permission
  3. Log with Alice
  4. Open the office document from the shared folder
  5. Alice is not able to open the Nextcloud right menu
    image

Expected behavior
Even if the sharing permission is denied, Alice should be able to open the right side menu, as for any other document with sharing permission.

Screenshots
See above

Client details:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
  • Device: [e.g. iPhone6, desktop]

Server details

t.nc.c
Operating system:

Web server:

Database:

PHP version:

Nextcloud version: 27.1.2

Version of the richdocuments app

Version of Collabora Online

Logs

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@juliushaertl
Copy link
Member

juliushaertl commented Dec 6, 2023

Yes, currently the sidebar button withing collabora is bound to the sharing option. This might be something to discuss with @pedropintosilva if we could separate that and have something like a file info button instead that we can show independently from sharing. This would also allow us to solve something that @schiessle recently mentioned to me that the talk sidebar is not accessible on public share links. (Edit: issue at #3328)

@juliushaertl juliushaertl added enhancement New feature or request 1. to develop Waiting for a developer feature: share link labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer enhancement New feature or request feature: share link
Projects
None yet
Development

No branches or pull requests

2 participants