Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DiscordWebSocket): Raise WebSocketClosure on protocol level errors #1180

Merged
merged 1 commit into from May 18, 2024
Merged

fix(DiscordWebSocket): Raise WebSocketClosure on protocol level errors #1180

merged 1 commit into from May 18, 2024

Conversation

Kevin-OVI
Copy link
Contributor

Summary

Prevents the bot from crashing with aiohttp.http_websocket.WebSocketError: Received fragmented control frame
Ported from Discord.py : Rapptz/discord.py@163a86c
Closes #1170

This is a Code Change

  • I have tested my changes. (I tested that bots work properly. It is difficult to say if the crash is actually solved because it seems to occur randomly.)

@Kevin-OVI
fix(DiscordWebSocket): Raise WebSocketClosure on protocol level errors
ae95c8a 
Prevents the bot from crashing with aiohttp.http_websocket.WebSocketError: Received fragmented control frame
Ported from Discord.py : Rapptz/discord.py@163a86c
@Kevin-OVI Kevin-OVI mentioned this pull request Apr 16, 2024
Closed
3 tasks
Skelmis
Skelmis approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, untested but lgtm since it's merged into dpy

EmreTech
EmreTech approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good

@EmreTech EmreTech added t: bug Type: bug - something isn't working p: low Priority: low - not important to be worked on labels May 18, 2024
@EmreTech EmreTech merged commit 108e957 into nextcord:master May 18, 2024
10 checks passed
@Kevin-OVI Kevin-OVI deleted the crash-fragmented-control-frame-fix branch May 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis approved these changes

@EmreTech EmreTech EmreTech approved these changes

Assignees
No one assigned
Labels
p: low Priority: low - not important to be worked on t: bug Type: bug - something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot crashing due to the error "aiohttp.http_websocket.WebSocketError: Received fragmented control frame"
3 participants
@Kevin-OVI @Skelmis @EmreTech