Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avatar decorations support #937

Open
ooliver1 opened this issue Dec 8, 2022 · 0 comments · May be fixed by #941
Open

Add avatar decorations support #937

ooliver1 opened this issue Dec 8, 2022 · 0 comments · May be fixed by #941
Labels
3.0 The issue/PR should go for the 3.0 release p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Milestone
3.0

Comments

@ooliver1
Copy link
Member

ooliver1 commented Dec 8, 2022 •
edited

Summary

Add avatar decorations to nextcord.

What is the feature request for?

The core library

The Problem

There is a nitro only feature - avatar decorations, which is available for bots to view on users, like banners.
image

The Ideal Solution

Add the cdn route to Asset as a constructor.

nextcord/nextcord/asset.py

Line 288 in 22eb5d1

def _from_user_banner(cls, state, user_id: int, banner_hash: str) -> Asset:

Add User.avatar_decoration.

nextcord/nextcord/user.py

Line 89 in 22eb5d1

def _update(self, data: Union[PartialUserPayload, UserPayload]) -> None:

The Current Solution

No response

Additional Context

discord/discord-api-docs#5723
@ooliver1 ooliver1 added p: medium Priority: medium - should be worked on in the near future help wanted Anyone is free to help, the issue shouldn't be *too* hard. t: api coverage Type: api coverage - this adds code to cover the discord API labels Dec 8, 2022
@Soheab Soheab linked a pull request Dec 8, 2022 that will close this issue
Open
7 tasks
@EmreTech EmreTech added s: awaiting review Status: the issue or PR is awaiting reviews and removed help wanted Anyone is free to help, the issue shouldn't be *too* hard. labels Dec 9, 2022
@EmreTech EmreTech linked a pull request Dec 9, 2022 that will close this issue
feat: avatar decorations #941
Open
7 tasks
@ooliver1 ooliver1 added the s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. label Dec 11, 2022
@EmreTech EmreTech removed the s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. label Aug 10, 2023
@ooliver1 ooliver1 added p: high Priority: high - should be worked on as soon as reasonable 3.0 The issue/PR should go for the 3.0 release and removed p: medium Priority: medium - should be worked on in the near future labels Mar 23, 2024
@ooliver1 ooliver1 added this to the 3.0 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 The issue/PR should go for the 3.0 release p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
No open projects
Nextcord progress
Status: In Cycle
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

feat: avatar decorations Soheab/nextcord
2 participants
@ooliver1 @EmreTech