Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: role subscriptions #940

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat: role subscriptions #940

wants to merge 19 commits into from
+118 −12

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Dec 8, 2022 •
edited

Summary

#938

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@EmreTech EmreTech changed the title chore: Add role subscription relevant attributes feat: role subscriptions Dec 9, 2022
@EmreTech EmreTech added s: stalled Status: the issue is stalled by other issues p: low Priority: low - not important to be worked on t: api coverage Type: api coverage - this adds code to cover the discord API p: medium Priority: medium - should be worked on in the near future and removed p: low Priority: low - not important to be worked on labels Dec 9, 2022
@EmreTech EmreTech linked an issue Dec 9, 2022 that may be closed by this pull request
Add role subscription relevant attributes #938
Open
@ooliver1 ooliver1 added s: awaiting review Status: the issue or PR is awaiting reviews s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. and removed s: stalled Status: the issue is stalled by other issues labels Dec 11, 2022
@ooliver1 ooliver1 removed the s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. label Jan 4, 2023
ooliver1
ooliver1 requested changes Jan 4, 2023
View reviewed changes
nextcord/types/guild.py Show resolved Hide resolved
nextcord/message.py Outdated Show resolved Hide resolved
@ooliver1 ooliver1 added p: high Priority: high - should be worked on as soon as reasonable 2.6 The issue/PR should go for the 2.6 release and removed p: medium Priority: medium - should be worked on in the near future labels Jun 16, 2023
@ooliver1 ooliver1 added this to the 2.6 milestone Jun 16, 2023
@ooliver1 ooliver1 self-requested a review June 16, 2023 12:30
teaishealthy
teaishealthy requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@teaishealthy teaishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. untested
  2. also needs updated versionadded

nextcord/role.py Outdated Show resolved Hide resolved
nextcord/message.py Outdated Show resolved Hide resolved
Soheab and others added 3 commits September 18, 2023 14:47
@Soheab Soheab mentioned this pull request Sep 18, 2023
Closed
3 tasks
ooliver1
ooliver1 requested changes Sep 19, 2023
View reviewed changes
nextcord/message.py Outdated Show resolved Hide resolved
Soheab and others added 2 commits September 20, 2023 07:26
@Soheab @ooliver1
docs: fix underline too long
008037e 
Co-authored-by: Oliver Wilkes <oliverwilkes2006@icloud.com>
@ooliver1
Merge branch 'master' into guild-role-subscription
644b847
@ooliver1 ooliver1 removed this from the 2.6 milestone Sep 23, 2023
@ooliver1 ooliver1 removed the 2.6 The issue/PR should go for the 2.6 release label Sep 23, 2023
Skelmis
Skelmis reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the comments this seems fine to me. I havent found the DAPI docs for a couple things but it all makes sense to me

nextcord/message.py Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
nextcord/role.py Outdated Show resolved Hide resolved
nextcord/role.py Outdated Show resolved Hide resolved
nextcord/role.py Outdated Show resolved Hide resolved
@ooliver1 ooliver1 added this to the 3.0 milestone Mar 23, 2024
@ooliver1 ooliver1 added the 3.0 The issue/PR should go for the 3.0 release label Mar 23, 2024
teaishealthy
teaishealthy approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@teaishealthy teaishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spifory spifory spifory left review comments

@teaishealthy teaishealthy teaishealthy approved these changes

@ooliver1 ooliver1 Awaiting requested review from ooliver1

@Skelmis Skelmis Awaiting requested review from Skelmis

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
3.0 The issue/PR should go for the 3.0 release p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
No open projects
Nextcord progress
Status: In Cycle
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Add role subscription relevant attributes
6 participants
@Soheab @ooliver1 @Skelmis @teaishealthy @spifory @EmreTech