Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction Subclasses #952

Open
spifory opened this issue Dec 14, 2022 · 1 comment · May be fixed by #970
Open

Interaction Subclasses #952

spifory opened this issue Dec 14, 2022 · 1 comment · May be fixed by #970
Assignees
Labels
p: low Priority: low - not important to be worked on s: in progress Status: the issue or PR is in development/progress t: refactor Type: refactor - this is a code change but does not fix a bug/add features

Comments

@spifory
Copy link
Collaborator

spifory commented Dec 14, 2022

Summary

There should be subclasses for Interaction depending on what the interaction is for.

What is the feature request for?

The core library

The Problem

I feel that there should be subclasses for Interaction since it would help provide the relevant attributes for certain situations. An example would be how <Interaction>.message should not work for modals (I think).

The Ideal Solution

Creating subclasses for Interaction in the library, like:

class Interaction:
    ...

class ModalInteraction(Interaction):
    ...

class ApplicationCommandInteraction(Interaction):
    ...

The Current Solution

No response

Additional Context

Disnake does do something like this, for reference.

@EmreTech EmreTech changed the title Creating Subclasses of Common Class Objects Interaction Subclasses Dec 25, 2022
@EmreTech EmreTech added p: low Priority: low - not important to be worked on help wanted Anyone is free to help, the issue shouldn't be *too* hard. t: refactor Type: refactor - this is a code change but does not fix a bug/add features labels Dec 25, 2022
@Gangsta-Muffin
Copy link

Gangsta-Muffin commented Jan 9, 2023

I will make an attempt at coding these items in the near future :)

~ Gangsta Muffin#5537

@ooliver1 ooliver1 added s: in progress Status: the issue or PR is in development/progress and removed help wanted Anyone is free to help, the issue shouldn't be *too* hard. labels Jan 9, 2023
@Gangsta-Muffin Gangsta-Muffin linked a pull request Jan 9, 2023 that will close this issue
11 tasks
@EmreTech EmreTech linked a pull request Jan 22, 2023 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Priority: low - not important to be worked on s: in progress Status: the issue or PR is in development/progress t: refactor Type: refactor - this is a code change but does not fix a bug/add features
Projects
No open projects
Status: In Cycle
Development

Successfully merging a pull request may close this issue.

4 participants