Skip to content

Commit

Permalink
Destroy the label editor & DOM on wire destroy
Browse files Browse the repository at this point in the history
  • Loading branch information
ericabouaf committed Aug 9, 2010
1 parent 3f60e6b commit 9e54179
Show file tree
Hide file tree
Showing 12 changed files with 58 additions and 5 deletions.
5 changes: 5 additions & 0 deletions VERSION.txt
Expand Up @@ -24,6 +24,11 @@ Changeset:
* Position constrained to (0,0) minimum
* Fix FormContainer terminals positioning if the fieldset is collapsed

* Adding 3 Containers :
* CanvasContainer : uses a canvas tag to render a container
* EllipseLabelContainer : inherits the CanvasContainer to draw an ellipse
* RectLabelContainer : Simple rect container with editable label

* Layer enhancements
* Export wires properties in getWiring method

Expand Down
2 changes: 1 addition & 1 deletion build/wireit-inputex-editor-composable-min.js

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build/wireit-inputex-editor-composable.js
Expand Up @@ -476,6 +476,14 @@ YAHOO.lang.extend(WireIt.Wire, WireIt.CanvasElement, {
// Remove references to old terminals
this.terminal1 = null;
this.terminal2 = null;

// Remove Label
if(this.labelEl) {
if(this.labelField) {
this.labelField.destroy();
}
this.labelEl.innerHTML = "";
}
},


Expand Down
2 changes: 1 addition & 1 deletion build/wireit-inputex-editor-grouping-min.js

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build/wireit-inputex-editor-grouping.js
Expand Up @@ -476,6 +476,14 @@ YAHOO.lang.extend(WireIt.Wire, WireIt.CanvasElement, {
// Remove references to old terminals
this.terminal1 = null;
this.terminal2 = null;

// Remove Label
if(this.labelEl) {
if(this.labelField) {
this.labelField.destroy();
}
this.labelEl.innerHTML = "";
}
},


Expand Down
2 changes: 1 addition & 1 deletion build/wireit-inputex-editor-min.js

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build/wireit-inputex-editor.js
Expand Up @@ -476,6 +476,14 @@ YAHOO.lang.extend(WireIt.Wire, WireIt.CanvasElement, {
// Remove references to old terminals
this.terminal1 = null;
this.terminal2 = null;

// Remove Label
if(this.labelEl) {
if(this.labelField) {
this.labelField.destroy();
}
this.labelEl.innerHTML = "";
}
},


Expand Down
2 changes: 1 addition & 1 deletion build/wireit-inputex-min.js

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build/wireit-inputex.js
Expand Up @@ -476,6 +476,14 @@ YAHOO.lang.extend(WireIt.Wire, WireIt.CanvasElement, {
// Remove references to old terminals
this.terminal1 = null;
this.terminal2 = null;

// Remove Label
if(this.labelEl) {
if(this.labelField) {
this.labelField.destroy();
}
this.labelEl.innerHTML = "";
}
},


Expand Down
2 changes: 1 addition & 1 deletion build/wireit-min.js

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build/wireit.js
Expand Up @@ -476,6 +476,14 @@ YAHOO.lang.extend(WireIt.Wire, WireIt.CanvasElement, {
// Remove references to old terminals
this.terminal1 = null;
this.terminal2 = null;

// Remove Label
if(this.labelEl) {
if(this.labelField) {
this.labelField.destroy();
}
this.labelEl.innerHTML = "";
}
},


Expand Down
8 changes: 8 additions & 0 deletions js/Wire.js
Expand Up @@ -206,6 +206,14 @@ YAHOO.lang.extend(WireIt.Wire, WireIt.CanvasElement, {
// Remove references to old terminals
this.terminal1 = null;
this.terminal2 = null;

// Remove Label
if(this.labelEl) {
if(this.labelField) {
this.labelField.destroy();
}
this.labelEl.innerHTML = "";
}
},


Expand Down

0 comments on commit 9e54179

Please sign in to comment.