Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add option for fixing the accessory name issue #118

Open
EnixCoda opened this issue Oct 23, 2023 · 0 comments
Open

[Feature Request] add option for fixing the accessory name issue #118

EnixCoda opened this issue Oct 23, 2023 · 0 comments

Comments

@EnixCoda
Copy link

Hi, thank you for this awesome project. I've set it up and My Model 3 has shown up in the Home App successfully.

I noticed the annoying accessory name issue mentioned in the readme. And read the issue of its fix. Found out that you've tried to fix it in 90609b6 but soon reverted in 2e52aad because The "ConfiguredName" characteristic did not behave as expected; it was impossible to set custom names through the Home app that persisted across Homebridge reboots

Then I tried to manually install the version of 90609b6 (which is 4.3.0 on NPM), it worked quite well for me because I do not need to rename them.

Now I am wondering if there could be an config field to optionally enable the fix for general users like myself. For example,

if (config.fixName) {
  // `fixName` can be configured via home bridge UI config page
  service.addOptionalCharacteristic(Characteristic.ConfiguredName);
  service.setCharacteristic(Characteristic.ConfiguredName, accessoryName);
}

I believe many users would be happy for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant