Amendments to allow for error code from _pcre_valid_utf8 being > 0, not >= 0

Author: nickgammon

ProcessPreviousLine.cpp

@@ -557,7 +557,7 @@ assemble the full text of the original line.
     {
     iBad = _pcre_valid_utf8 ((const unsigned char *) (const char *) strCurrentLine, 
                              strCurrentLine.GetLength ());
-    if (iBad >= 0)
+    if (iBad > 0)
       {
        m_iUTF8ErrorCount++;
 

Utilities.cpp

@@ -2889,7 +2889,7 @@ int UMessageBox (const char * sText, UINT nType, const char * sTitle)
   iBad = _pcre_valid_utf8 ((unsigned char  *) sTitle, strlen (sTitle));
 
   // use PCRE to validate the title next - if bad, use "MUSHclient" title
-  if (iBad >= 0)
+  if (iBad > 0)
      sTitle = "MUSHclient";
 
   iLength = MultiByteToWideChar (CP_UTF8, 0, sTitle, -1, NULL, 0);

miniwindow.cpp

@@ -764,7 +764,7 @@ static long CalculateUTF8length (LPCTSTR Text, size_t length)
   {
 
   int iBad = _pcre_valid_utf8 ((unsigned char  *) Text, length);
-  if (iBad >= 0)
+  if (iBad > 0)
     return -1;
 
     // string is OK, calculate its length

scripting/lua_utils.cpp

@@ -1114,7 +1114,7 @@ const char * data = luaL_checkstring (L, 1);
   int iBad = _pcre_valid_utf8 ((unsigned char  *) data, strlen (data));
 
   // use PCRE to validate the string first
-  if (iBad >= 0)
+  if (iBad > 0)
     luaL_error (L, "Bad UTF-8 string. Error at column %d", iBad + 1);
 
   // find how big table has to be
@@ -1157,7 +1157,7 @@ const char * data = luaL_checkstring (L, 1);
   int iBad = _pcre_valid_utf8 ((unsigned char  *) data, strlen (data));
 
   // use PCRE to validate the string first
-  if (iBad >= 0)
+  if (iBad > 0)
     luaL_error (L, "Bad UTF-8 string. Error at column %d", iBad + 1);
 
   lua_newtable (L);    // table of wide characters
@@ -1348,7 +1348,7 @@ const char * data = luaL_checklstring (L, 1, &length);
 
   int iBad = _pcre_valid_utf8 ((unsigned char  *) data, length);
 
-  if (iBad >= 0)
+  if (iBad > 0)
     {
     lua_pushnil (L);
     lua_pushnumber (L, iBad + 1);
@@ -1393,7 +1393,7 @@ static int utf8sub (lua_State *L) {
 
   int iBad = _pcre_valid_utf8 ((unsigned char  *) s, length);
 
-  if (iBad >= 0)
+  if (iBad > 0)
     {
     lua_pushnil (L);
     lua_pushnumber (L, iBad + 1);