Improved Config_Option_Changer plugin

Author: nickgammon

plugins/Config_Option_Changer.xml

@@ -1,9 +1,5 @@
 <?xml version="1.0" encoding="iso-8859-1"?>
 <!DOCTYPE muclient>
-<!-- Saved on Monday, August 09, 2010, 10:29 AM -->
-<!-- MuClient version 4.56 -->
-
-<!-- Plugin "Config_Option_Changer" generated by Plugin Wizard -->
 
 <muclient>
 <plugin
@@ -13,8 +9,9 @@
    language="Lua"
    purpose="Changes options not available in GUI configuration"
    date_written="2010-08-09 10:28:14"
+   date_modified="2010-08-10 09:50"
    requires="4.50"
-   version="1.0"
+   version="2.0"
    >
 <description trim="y">
 <![CDATA[
@@ -63,9 +60,9 @@ boolean_options = {
   default_trigger_expand_variables      = { desc = 'New triggers: default to expand variables?' },
   default_trigger_keep_evaluating       = { desc = 'New triggers: default to keep evaluating?' },
   default_trigger_ignore_case           = { desc = 'New triggers: default to ignore case?' },
-  do_not_add_macros_to_command_history  = { desc = 'Do not add macros to command history?' },
-  do_not_show_outstanding_lines         = { desc = 'Do not show outstanding lines count?' },
-  do_not_translate_iac_to_iac_iac       = { desc = 'Do not translate IAC to IAC IAC?' },
+  do_not_add_macros_to_command_history  = { desc = 'Add macros to command history?' , invert = true },
+  do_not_show_outstanding_lines         = { desc = 'Show outstanding lines count?' , invert = true  },
+  do_not_translate_iac_to_iac_iac       = { desc = 'Translate IAC to IAC IAC?' , invert = true  },
   play_sounds_in_background             = { desc = 'Play sounds in background?' },
   send_keep_alives                      = { desc = 'Send keep-alives?' },
   } -- end boolean_options
@@ -85,24 +82,41 @@ numeric_options = {
 function edit_boolean_option (name)
   local val = GetOption (name)
   local info = boolean_options [name]
+  
   local default = 1  -- default to "Yes" button
    
   -- if option not set, default to "No" button
-  if val == 0 then
-    default = 2
+  if (val == 0 and not info.invert) or
+     (val == 1 and info.invert) then
+    default = 2  -- default is "No" button
   end -- if
 
   -- what do they *really* want?
   local response = utils.msgbox (info.desc, "Change option", "yesnocancel", "?", default )
   
+  -- if cancelled dialog, just return
+  if response == "cancel" then
+    return
+  end -- if cancelled
+
+  -- if inverted question, we invert the response meaning  
+  local newval = 0
+  
+  if info.invert then
+    if response == "no" then
+      newval = 1
+    end -- if
+  else
+    if response == "yes" then
+      newval = 1
+    end -- if
+  end -- if
+  
   -- notify if switched
-  if response == "yes" and val == 0 then
-    SetOption (name, 1)
-    ColourNote ("cyan", "", "Option " .. name .. " changed to: Yes")
-  elseif response == "no" and val == 1 then
-    SetOption (name, 0)
-    ColourNote ("cyan", "", "Option " .. name .. " changed to: No")
-  end -- if  
+  if val ~= newval then
+    SetOption (name, newval)
+    ColourNote ("cyan", "", "Option '" .. info.desc .. "' changed to: " .. response)
+  end -- if
   
 end -- edit_boolean_option
 
@@ -112,10 +126,15 @@ function edit_alpha_option (name)
 
   local response = utils.inputbox (info.desc, "Change option", val, "Courier", 9)
   
-  -- if not cancelled, and value change, notify them
-  if response and response ~= val then
+  -- if cancelled dialog, just return
+  if not response then
+    return
+  end -- cancelled
+  
+  -- if value changed, notify them
+  if response ~= val then
     SetAlphaOption (name, response)
-    ColourNote ("cyan", "", string.format ("Option %s changed from '%s' to '%s'", name, val, response))
+    ColourNote ("cyan", "", string.format ("Option '%s' changed from '%s' to '%s'", info.desc, val, response))
   end -- if  
   
 end -- edit_alpha_option
@@ -127,11 +146,12 @@ function edit_numeric_option (name)
   local response = utils.inputbox (
               string.format ("%s\r\n\r\nRange: %i to %i", info.desc, info.min, info.max), 
                              "Change option", val, "Courier", 9)
-  
+
+  -- if cancelled dialog, just return
   if not response then
     return
   end -- cancelled
-  
+ 
   -- check numeric
   n = tonumber (response)
  
@@ -152,7 +172,7 @@ function edit_numeric_option (name)
   -- notify them if value changed                 
   if n ~= val then
     SetOption (name, n)
-    ColourNote ("cyan", "", string.format ("Option %s changed from %i to %i", name, val, n))
+    ColourNote ("cyan", "", string.format ("Option '%s' changed from %i to %i", info.desc, val, n))
   end -- if  
   
 end -- edit_numeric_option
@@ -176,7 +196,8 @@ function config_options (name, line, wildcards)
     for k, v in pairs (boolean_options) do
       local val = GetOption (k)
       local yes_no = "Yes"
-      if val == 0 then
+      if (val == 0 and not v.invert) or
+         (val == 1 and v.invert) then
         yes_no = "No"
       end -- if
       if val then