Added warning dialog box if attempt to get help under Windows 10+

Author: nickgammon

MUSHclient.cpp

@@ -883,8 +883,8 @@ OSVERSIONINFO VersionInformation;
 
   pMainFrame->SendMessage (WM_COMMAND, ID_WORLDS_WORLD1, 0);
 
-  if (firsttime && !bWine)
-    App.WinHelp(ID_GETTING_STARTED + HID_BASE_COMMAND);	
+  if (firsttime && !bWine && HelpAvailable (false))
+    App.HelpHelper(ID_GETTING_STARTED + HID_BASE_COMMAND);
 
   App.ShowTipAtStartup();
 
@@ -1300,7 +1300,7 @@ void CMUSHclientApp::OnFileNew()
 
 void CMUSHclientApp::OnHelpGettingstarted() 
 {
-App.WinHelp(ID_GETTING_STARTED + HID_BASE_COMMAND);	
+App.HelpHelper(ID_GETTING_STARTED + HID_BASE_COMMAND);
 }
 
 bool GetSelection (CEdit * pEdit, CString & strSelection)
@@ -2194,3 +2194,36 @@ void CMUSHclientApp::WorkOutFixedFont ()
 
 
   } // end of CMUSHclientApp::WorkOutFixedFont
+
+
+// Winhelp not available in Windows 10, nor any alternative
+bool CMUSHclientApp::HelpAvailable (bool showWarning)
+  {
+  if (os_version.dwPlatformId == VER_PLATFORM_WIN32_NT && os_version.dwMajorVersion >= 10)
+    {
+    if (showWarning)
+      TMessageBox("Supplied help file is not compatible with Windows 10 and above.\r\n\r\n"
+                  "Suggest you install the plugin \"MUSHclient_Help\" for browsing the help file, "
+                  "and then type \"mchelp <subject>\"."
+                  "\r\n\r\nOr, view the online help at: http://mushclient.com/scripts/doc.php", MB_ICONINFORMATION); 
+    return false;
+    }
+
+
+  return true;
+  }
+
+// show help if we can
+void CMUSHclientApp::HelpHelper (DWORD dwData, UINT nCmd)
+  {
+
+  if (!HelpAvailable (true))
+    return;
+
+  // show help normally
+  if (dwData == 0)
+    OnHelp ();
+  else
+    App.WinHelp (dwData, nCmd);
+
+  } // end of CMUSHclientApp::HelpHelper

MUSHclient.h

@@ -288,6 +288,9 @@ class CMUSHclientApp : public CWinApp
 
   void WorkOutFixedFont ();
 
+  bool HelpAvailable (bool showWarning);  // can we show help or not?
+  void HelpHelper( DWORD dwData, UINT nCmd = HELP_CONTEXT );
+
   /*
   virtual void OnFinalRelease()
     {

dialogs/cmdhist.cpp

@@ -120,7 +120,7 @@ void CCmdHistory::OnDblclkCommands()
 void CCmdHistory::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);	
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 }
 
 void CCmdHistory::OnFind() 

dialogs/logdlg.cpp

@@ -71,6 +71,6 @@ END_MESSAGE_MAP()
 void CLogDlg::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);	
-	App.WinHelp(m_nIDHelp + HID_BASE_COMMAND);
+	App.HelpHelper(m_nIDHelp + HID_BASE_COMMAND);
 
 }

dialogs/password.cpp

@@ -62,5 +62,5 @@ END_MESSAGE_MAP()
 void CPasswordDialog::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);	
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 }

dialogs/world_prefs/EditVariable.cpp

@@ -84,7 +84,7 @@ END_MESSAGE_MAP()
 void CEditVariable::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 
 }
 

dialogs/world_prefs/TimerDlg.cpp

@@ -306,7 +306,7 @@ void CTimerDlg::OnButtonEvery()
 void CTimerDlg::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);	
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 }
 
 BOOL CTimerDlg::OnInitDialog() 

dialogs/world_prefs/aliasdlg.cpp

@@ -350,7 +350,7 @@ END_MESSAGE_MAP()
 void CAliasDlg::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);	
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 }
 
 

dialogs/world_prefs/editmac.cpp

@@ -54,7 +54,7 @@ END_MESSAGE_MAP()
 void CEditMacro::OnHelpbutton() 
 {
 //	  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);	
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 }
 
 void CEditMacro::OnEdit() 

dialogs/world_prefs/triggdlg.cpp

@@ -453,7 +453,7 @@ void CTriggerDlg::OnTestSound()
 void CTriggerDlg::OnHelpbutton() 
 {
 //  OnCmdMsg(ID_HELP, CN_COMMAND, NULL, NULL);
-	App.WinHelp(m_nIDHelp + HID_BASE_RESOURCE);
+	App.HelpHelper(m_nIDHelp + HID_BASE_RESOURCE);
 }