Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info screen about drivers needed for remote and media key extensions #292

Open
johnmurrayvi opened this issue May 3, 2014 · 8 comments · May be fixed by #366
Open

Add info screen about drivers needed for remote and media key extensions #292

johnmurrayvi opened this issue May 3, 2014 · 8 comments · May be fixed by #366
Milestone

Comments

@johnmurrayvi
Copy link
Member

johnmurrayvi commented May 3, 2014

With #284 merged, and new deps, the dock menu works again.
The media keys extensions requires http://www.thebitguru.com/projects/iTunesPatch
to break the absurd monopoly iTunes has on media keys.
The remote extension requires the "legacy Candelair driver" to work correctly.

Basically, the user just needs to be informed of this, if they do not already have them.

Chances are, most people using a media player besides iTunes on a mac already know about the first patch. I'm not sure the same can be said about the remote though.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1972039-add-info-screen-about-drivers-needed-for-remote-and-media-key-extensions?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github).
@johnmurrayvi johnmurrayvi added this to the 1.12.2 milestone May 3, 2014
@zjays
Copy link
Contributor

zjays commented Aug 28, 2015

I updated the apple-remote extension to use the "HIDRemote" class: https://github.com/zjays/nightingale-hacking/commits/mac-remote-mediakey-testing (will create a pull request later)

With this, users on Mac OS X 10.6.1+ (which should be pretty much all of our Mac users) don't have to install the Candelair driver any more. Also, it turns out that when the apple-remote extension is activated, it takes exclusive control of the Apple remote, so pressing Play on the remote won't launch iTunes.

So http://www.thebitguru.com/projects/iTunesPatch is only required to stop iTunes from launching when pressing Play/Pause media keys on the keyboard. Do we still want to have some sort of warning dialogue informing the user of this? I don't know how to implement it directly into the apple-mediakeys extension - maybe we can just add a note somewhere on the Wiki or on the First run page of the new website?

@freaktechnik
Copy link
Member

MAking a warning dialogue would require no effort, as long as it doesn't have to contain links.

@zjays
Copy link
Contributor

zjays commented Aug 28, 2015

I was thinking a warning dialogue should contain a link to http://www.thebitguru.com/projects/iTunesPatch. It should also have a checkbox or something similar for the user to indicate that they don't want the warning to keep popping up.

Does anyone know of a similar example to the above from the Nightingale codebase or an add-on that I could use as a template? Not sure if I can use info from Mozilla Developer Network as I don't know if everything will apply to Nightingale's old XULRunner.

@freaktechnik
Copy link
Member

Well, the warning dialog would only be shown once and then a pref would be set that it was shown. If there wasn't a link in it, you could just use window.alert() and use a string from a stringbundle (most likely from songbird.properties) and only show it when the pref is false and then set the pref to true once it's been shown once.

If not, for example the equalizerpreset dialog is a good example, however that's in core and not an extension.

@zjays
Copy link
Contributor

zjays commented Aug 29, 2015

Thanks! I'll have a look.

@zjays
Copy link
Contributor

zjays commented Aug 31, 2015

Here's what I came up with: f507c1d

The message in the first screenshot shows only on the first run of a fresh profile. I couldn't figure out how to get the message to pop up upon the first Play/Pause media key press. However, the message also lets the user know they can use a Bluetooth device with some extra steps. I put the detailed instructions in a preference pane for the extension.

mac media keys firstrun message
mac media keys prefpane

@freaktechnik
Copy link
Member

That looks pretty nice. For better future proofing I'd suggest running the firstrun stuff in a component (see for example the amazon music extension, or the store extensions in the addons repo).

@zjays
Copy link
Contributor

zjays commented Oct 26, 2015

So I ran into trouble when trying to run the firstrun script in a component. I can't remember exactly what the problem was, but I ran out of time and probably won't have time to figure it out before the next Nightingale release. So I'm going to make a pull request for the above changes now, before I forget.

@zjays zjays linked a pull request Oct 26, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants