Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve posix module #10723

Merged
merged 1 commit into from Feb 28, 2019
Merged

Improve posix module #10723

merged 1 commit into from Feb 28, 2019

Conversation

FedericoCeratto
Copy link
Member

Add docstrings and some helper functions.

lib/posix/posix.nim Outdated Show resolved Hide resolved
@Araq
Copy link
Member

Araq commented Feb 25, 2019

I appreciate the additions but posix.nim is supposed to only be a wrapper, not provide convenience procs. For example, with your additions it is not clear anymore that none of these procs raise exceptions, because the new ones now do raise. Please move them to a new module posix_utils.nim or similar.

lib/posix/posix.nim Outdated Show resolved Hide resolved
@juancarlospaco
Copy link
Collaborator

juancarlospaco commented Feb 26, 2019

If the code is homeless and is not getting into std lib,
I maintain psutil module that has a posix module extends std libs one, more than welcome to add it there, just saying. 🙂 Awesome work whatsoever.

@Araq
Copy link
Member

Araq commented Feb 28, 2019

Looks good to me. Please also add it to kochdocs.nim and the changelog.

@FedericoCeratto
Copy link
Member Author

@Araq updated. Should the entries in tools/kochdocs.nim sorted alphanumerically later on?

@Araq
Copy link
Member

Araq commented Feb 28, 2019

@Araq updated. Should the entries in tools/kochdocs.nim sorted alphanumerically later on?

Nah.

@Araq Araq merged commit 7d7cd69 into nim-lang:devel Feb 28, 2019
FedericoCeratto added a commit to FedericoCeratto/Nim that referenced this pull request Oct 24, 2019
narimiran pushed a commit that referenced this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants