New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve posix module #10723
Improve posix module #10723
Conversation
bf3b476
to
ca2afce
Compare
ca2afce
to
3ce4dbe
Compare
I appreciate the additions but posix.nim is supposed to only be a wrapper, not provide convenience procs. For example, with your additions it is not clear anymore that none of these procs raise exceptions, because the new ones now do raise. Please move them to a new module |
If the code is homeless and is not getting into std lib, |
3ce4dbe
to
3a3dabf
Compare
Looks good to me. Please also add it to |
3a3dabf
to
6b9c650
Compare
@Araq updated. Should the entries in tools/kochdocs.nim sorted alphanumerically later on? |
Nah. |
Add docstrings and some helper functions.