Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Add a confirmation before opening new issue #534

Open
wigust opened this issue Mar 26, 2018 · 4 comments
Open

Add a confirmation before opening new issue #534

wigust opened this issue Mar 26, 2018 · 4 comments

Comments

@wigust
Copy link

wigust commented Mar 26, 2018

Hello, Could you add a confirmation input similar to $ git send-email for gh issue foo? So in order to open new issue you should type y or n to reject. Also a flag -y to run it non-interactively.

@protoEvangelion
Copy link
Member

@wigust Do you see this as applying only when opening an issue?

Or could you see this being used in other use cases like commenting on an issue or PR?

@wigust
Copy link
Author

wigust commented Apr 23, 2018

@protoEvangelion, I'm not sure about other use cases, because e.g. commenting on an issue requires to type a specific flag. But to be more identical in commands for online activity which creates something on GitHub a necessity of -y flag to send without asking is a good idea.

I'm sure it would be nice in case of gh pull-request MESSAGE and gh issue MESSAGE.

@protoEvangelion
Copy link
Member

Hmm... I definitely like the pattern of using -y for non interactive mode, but I would be hesitant to change the UX to require user feedback for each main action like sending PRs or creating new issues.

The main reason for that is because a lot of people use gh ... in aliases or scripts and this type of functionality would break their scripts if they don't include -y.

Any ideas on how to overcome that challenge?

@wigust
Copy link
Author

wigust commented May 5, 2018

The main reason for that is because a lot of people use gh ... in aliases or scripts and this type of functionality would break their scripts if they don't include -y.

Any ideas on how to overcome that challenge?

I think we could have a release with a warning to give people some time for a switch to new syntax. E.g.: “gh pull-request MESSAGE, gh issue MESSAGE, gh … commands syntax will change in a feature release, requiring you to specify -y flag to send non-interactively”

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants