Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp conversion does not account for floating point errors #606

Open
revbingo opened this issue Dec 7, 2021 · 0 comments · May be fixed by #607
Open

Timestamp conversion does not account for floating point errors #606

revbingo opened this issue Dec 7, 2021 · 0 comments · May be fixed by #607

Comments

@revbingo
Copy link
Contributor

revbingo commented Dec 7, 2021

Expected Behavior

Given a nano timestamp from Influx of 1638842483690000000, the RFC3339 date in the result set should be 2021-12-07T02:01:23.690Z

Actual Behavior

The resultset contains the timestamp 2021-12-07T02:01:23.689Z.

This is because the timetoDate function divides the nano timestamp by Math.pow(10,6), which due to FP constraints results in 1638842483689.9998

Steps/Code to Reproduce the Problem

  1. Insert a record with the nano second timestamp 1638842483690000000
  2. Use the client to query the record with ms precision. The timestamp will be presented as 2021-12-07T02:01:23.689Z

Pull request incoming...
revbingo added a commit to revbingo/node-influx that referenced this issue Dec 7, 2021
@revbingo
fix: node-influx#606 - Timestamp conversion subject to floating point…
e6d68dd 
… errors
revbingo added a commit to revbingo/node-influx that referenced this issue Dec 7, 2021
@revbingo
fix: node-influx#606 - Timestamp conversion subject to floating point…
02b4e46 
… errors
@revbingo revbingo linked a pull request Dec 7, 2021 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #606 - Timestamp conversion subject to floating point errors revbingo/node-influx
1 participant
@revbingo