You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have two possible PUT reuquests on /apps/<appname> -- one for updating the starting app name, and another for starting/stopping the app.
Taking two completely separate actions, depending on the key sent, is problematic, because the convention is to send the full model when doing a PUT request.
This is causing a problem with the admin panel:
Start/stop an app as appropriate
Response has start attribute, which gets copied to the model
Start/stop the same app without refreshing page
Full model info, including both runningandstart attributes is sent to the API. That seems to trigger the starting app name update, not the start/stop app action.
Suggested changes:
API needs to check for changes on both attributes when a PUT request is sent to this endpoint
Respective actions should be triggered only if the value is changed
The text was updated successfully, but these errors were encountered:
We have two possible PUT reuquests on
/apps/<appname>
-- one for updating the starting app name, and another for starting/stopping the app.Taking two completely separate actions, depending on the key sent, is problematic, because the convention is to send the full model when doing a PUT request.
This is causing a problem with the admin panel:
start
attribute, which gets copied to the modelrunning
andstart
attributes is sent to the API. That seems to trigger the starting app name update, not the start/stop app action.Suggested changes:
The text was updated successfully, but these errors were encountered: