Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking the media type after fetching the blob is slow #215

Open
patrickzheng200 opened this issue Nov 23, 2022 · 1 comment
Open

Checking the media type after fetching the blob is slow #215

patrickzheng200 opened this issue Nov 23, 2022 · 1 comment
Milestone
Discuss

Comments

@patrickzheng200
Copy link
Contributor

patrickzheng200 commented Nov 23, 2022 •
edited

The performance of this check is slow since it checks the media type after fetching the blob.
if len(remoteOpts.SignatureMediaTypes) != 0 && !slices.Contains(remoteOpts.SignatureMediaTypes, sigDesc.MediaType)

Originally posted by @shizhMSFT in #208 (comment)
@patrickzheng200 patrickzheng200 mentioned this issue Nov 23, 2022
Merged
@patrickzheng200 patrickzheng200 changed the title checking the media type after fetching the blob is slow Check the media type after fetching the blob is slow Nov 23, 2022
@patrickzheng200 patrickzheng200 changed the title Check the media type after fetching the blob is slow Checking the media type after fetching the blob is slow Nov 23, 2022
@priteshbandi priteshbandi added this to the RC-2 milestone Nov 23, 2022
@patrickzheng200
Copy link
Contributor Author

patrickzheng200 commented Nov 25, 2022 •
edited

Closing this issue since we decided to remove this logic from RC-1. If we decide to bring it back in RC-2 we should re-open this issue.

@yizha1 yizha1 modified the milestones: RC-2, Discuss Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Notary Project Planning Board
Status: In Progress
Milestone
Discuss
Development

No branches or pull requests
3 participants
@priteshbandi @patrickzheng200 @yizha1