Compilation problem

[marco44]

Hi,

I'm maintaining the arch package…

While trying to build, I get this error:

marc@marco:~/mp4fpsmod$ make
make  all-recursive
make[1]: Entering directory '/home/marc/Downloads/developpement/aur/mp4fpsmod/src/mp4fpsmod'
Making all in mp4v2
make[2]: Entering directory '/home/marc/Downloads/developpement/aur/mp4fpsmod/src/mp4fpsmod/mp4v2'
/bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H   -I./include -I./include -I. -I.  -Wall -Wformat -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -fvisibility=hidden -c -o src/rtphint.lo src/rtphint.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I./include -I./include -I. -I. -Wall -Wformat -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -fvisibility=hidden -c src/rtphint.cpp -o src/rtphint.o
In file included from ./src/src.h:28:0,
                 from ./src/impl.h:6,
                 from src/rtphint.cpp:22:
./src/mp4util.h:36:33: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
             throw new Exception("assert failure: "LIBMPV42_STRINGIFY((expr)), __FILE__, __LINE__, __FUNCTION__ ); \
                                 ^
src/rtphint.cpp: In member function 'void mp4v2::impl::MP4RtpHintTrack::GetPayload(char**, uint8_t*, uint16_t*, char**)':
src/rtphint.cpp:342:35: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
                     if (pSlash != '\0') {
                                   ^~~~
make[2]: *** [GNUmakefile:1085: src/rtphint.lo] Error 1
make[2]: Leaving directory '/home/marc/Downloads/developpement/aur/mp4fpsmod/src/mp4fpsmod/mp4v2'
make[1]: *** [Makefile:566: all-recursive] Error 1
make[1]: Leaving directory '/home/marc/Downloads/developpement/aur/mp4fpsmod/src/mp4fpsmod'
make: *** [Makefile:367: all] Error 2

Changing pSlash != '\0' to *pSlash != '\0' makes it compile (it seemed logical to me, but I only gave it a very quick look).

Regards

[nu774]

Thanks, fixed it now.

[qo4on]

Is it fixed? I also have the same error.

I do the following in Colab:

!git clone -qqq https://github.com/nu774/mp4fpsmod.git > /dev/null
!sudo apt-get update -y -qqq --fix-missing && apt-get install -y -qqq autoconf libtool > /dev/null
%cd mp4fpsmod
!./bootstrap.sh
!./configure

All the above commands were done successfully but when I run make I get into a loop:

!make

make  all-recursive
make[1]: Entering directory '/content/mp4fpsmod'
Making all in mp4v2
make[2]: Entering directory '/content/mp4fpsmod/mp4v2'
/bin/bash ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H   -I./include -I./include -I. -I.  -Wall -Wformat -g -O2 -fvisibility=hidden -c -o src/3gp.lo src/3gp.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I./include -I./include -I. -I. -Wall -Wformat -g -O2 -fvisibility=hidden -c src/3gp.cpp -o src/3gp.o
In file included from ./src/src.h:28:0,
                 from ./src/impl.h:6,
                 from src/3gp.cpp:28:
./src/mp4util.h:36:33: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
             throw new Exception("assert failure: "LIBMPV42_STRINGIFY((expr)), __FILE__, __LINE__, __FUNCTION__ ); \
                                 ^
/bin/bash ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H   -I./include -I./include -I. -I.  -Wall -Wformat -g -O2 -fvisibility=hidden -c -o src/atom_ac3.lo src/atom_ac3.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I./include -I./include -I. -I. -Wall -Wformat -g -O2 -fvisibility=hidden -c src/atom_ac3.cpp -o src/atom_ac3.o
In file included from ./src/src.h:28:0,
                 from ./src/impl.h:6,
                 from src/atom_ac3.cpp:24:
./src/mp4util.h:36:33: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
             throw new Exception("assert failure: "LIBMPV42_STRINGIFY((expr)), __FILE__, __LINE__, __FUNCTION__ ); \

How can I fix this?