Fix potential error in rewrite fast locals on 3.12 for #548 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frmdstryr
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 70.74% 70.75%
=======================================
Files 287 287
Lines 25634 25638 +4
Branches 4676 4678 +2
=======================================
+ Hits 18135 18139 +4
Misses 6386 6386
Partials 1113 1113 |
|
Thanks for the PR. I will try to look into the bytecode causing the error before merging to understand why 3.12 uses a try/begin here. |
|
Thanks for the fix. Would you be so kind as to add an entry in the changelog ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few isinstance checks needed in rewrite_fast_locals on python 3.12. Fixes #548