After upgrade from version 3.14.0 to 4.* running multiple test categories in parentheses separated with 'OR' stopped working

[cjohnsson]

Versions of lib
.NET 6, NUnit 4.1.0 with NUnit3TestAdapter 4.5.0 and Microsoft.NET.Test.Sdk 17.9.0.

Command to execute tests
dotnet test "testingnunit.dll" --verbosity d --filter "(TestCategory=TestsA&TestCategory!=TestsB)|(TestCategory=TestsC)"

How to reproduce

1. Create a project called testingnunit with the provided example class in it. Build the project.
2. Run the test command, no tests will be found when running with NUnit version 4.0.0 or later.
   Output is "No test matches the given testcase filter".
   
3. If you downgrade NUnit to version 3.14.0 and run the test command it finds the tests. TestInA and TestInC are exectued, TestInB is excluded as expected.
   

How to mitigate the problem when running with NUnit 4.1.0
Run dotnet test for each filter within parentheses.
First run dotnet test "testingnunit.dll" --verbosity d --filter "(TestCategory=TestsA&TestCategory!=TestsB)", and then run dotnet test "testingnunit.dll" --verbosity d --filter "(TestCategory=TestsC)"

Code example

<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <TargetFramework>net6.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
    </PropertyGroup>

    <ItemGroup>
      <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
      <PackageReference Include="NUnit" Version="4.1.0" />
      <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
    </ItemGroup>
</Project>

using NUnit.Framework;

namespace TestingNunit;

[TestFixture, Category("TestsA")]
public class TestsA
{
    [Test]
    public void TestInA()
    {
        Assert.Pass();
    }
}

[TestFixture, Category("TestsB")]
public class TestsB
{
    [Test]
    public void TestInB()
    {
        Assert.Fail();
    }
}

[TestFixture, Category("TestsC")]
public class TestsC
{
    [Test]
    public void TestInC()
    {
        Assert.Pass();
    }
}

[cjohnsson]

The above is a problem if you have a project with many test categories and want to create complex filters.

In my case I want to execute all tests that are not ignored for a module, except the ones that are categorized as slow/obtrusive, and I also want to include not ignored cross-module "smoketests".

My test filter that works in NUnit 3.14.0 but fails to find any tests in NUnit 4.1.0
(TestCategory=MyModule&TestCategory!=Obtrusive&TestCategory!=Slow&TestCategory!=Ignored)|(TestCategory=Smoketest&TestCategory!=Ignored)

[OsirisTerje]

Thanks! So with 3.14.0 and adapter 4.5.0 it works, but with 4.1.0 and adapter 4.5.0 it doesn't work?

[cjohnsson]

Thanks! So with 3.14.0 and adapter 4.5.0 it works, but with 4.1.0 and adapter 4.5.0 it doesn't work?

Exactly.