NuProj auto-detection of packages folder is not always working

[ivan-sam]

NuProj ReadPackagesConfig task tries to locate package directory path (PackageReferences.PackageDirectoryPath metadata) by probing directories <currentDir>\packages\<package-id>.<package-version> starting from project's directory all the way up.

Later PackageDirectoryPath is used to exclude libraries coming from NuGet dependencies from final package files list (target GetPackageFiles).

I found NuGet dependency library in output package's lib folder while migration NuGet projects from using NuBuild to NuProj. Investigation showed that layout of solution caused the problem: solution file is located in it's own subfolder. packages folder by convention is located near the solution file.

│   
├───NuGetPackage1
│       packages.config
│       Readme.txt
│       TestProjNuGet.nuproj
│       
├───solutions
│   │   NuProjTest.sln
│   │   
│   └───packages
│       ├───Newtonsoft.Json.11.0.2
│       │   │   LICENSE.md
│       │   │   Newtonsoft.Json.11.0.2.nupkg
│       │   │   
│       │   └───lib
│       │               
│       │               
│       ├───NuProj.0.20.9-beta
│       │   │   NuProj.0.20.9-beta.nupkg
│       │   │   
│       │   ├───build
│       │   │       NuProj.props
│       │   │       
│       │   └───tools
│       │       │   
│       │       └───Rules
│       │               
│       │               
│       └───NuProj.Common.0.20.9-beta
│           │   NuProj.Common.0.20.9-beta.nupkg
│           │   
│           └───build
│               │   NuProj.Common.targets
│               │   
│               ├───dotnet
│               │       NuProj.Common.targets
│               │       
│               └───portable-net+win+wpa+wp+sl+netmf+MonoAndroid+MonoTouch+Xamarin.iOS
│                       NuProj.Common.targets
│                       
├───TestProj
│   │   Class1.cs
│   │   packages.config
│   │   TestProj.csproj
│   │   
│   └───Properties
│           AssemblyInfo.cs
│           
└───TestProj.Interface
    │   Interface1.cs
    │   TestProj.Interface.csproj
    │   
    └───Properties
            AssemblyInfo.cs
            

And here's the code reference that does wrong guessing of packages directory location:

nuproj/src/NuProj.Tasks/ReadPackagesConfig.cs

Lines 66 to 80 in 55350b5

	private static string GetPackageDirectoryPath(string packagesConfigPath, string packageId, SemanticVersion packageVersion)
	{
	var packageDirectoryName = packageId + "." + packageVersion;
	var candidateFolder = Path.GetDirectoryName(packagesConfigPath);
	while (candidateFolder != null)
	{
	var packageDirectoryPath = Path.Combine(candidateFolder, "packages", packageDirectoryName);
	if (Directory.Exists(packageDirectoryPath))
	return packageDirectoryPath;
	candidateFolder = Path.GetDirectoryName(candidateFolder);
	}
	return string.Empty;
	}