Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

<ExcludeFromNuPkg> not working when <HintPath> exists #306

Open
JasonMrX opened this issue Nov 23, 2018 · 2 comments
Open

<ExcludeFromNuPkg> not working when <HintPath> exists #306

JasonMrX opened this issue Nov 23, 2018 · 2 comments

Comments

@JasonMrX
Copy link

JasonMrX commented Nov 23, 2018

<ExcludeFromNuPkg> NOT taking effect in the following example:

<Reference Include="SomeLibrary.dll" Condition="'$(SomeKey)'=='someValue'">
  <HintPath>$(SomeHint)\SomeFolder\SomeLibrary.dll</HintPath>
  <ExcludeFromNuPkg>true</ExcludeFromNuPkg>
  <Private>true</Private>
</Reference>

To bypass the issue, we have to get rid of the <HintPath> tag, which doesn't make sense to us:

<Reference Include="$(SomeHint)\SomeFolder\SomeLibrary.dll" Condition="'$(SomeKey)'=='someValue'">
  <ExcludeFromNuPkg>true</ExcludeFromNuPkg>
  <Private>true</Private>
</Reference>

Just wondering if this is known/expected.

Thanks folks for the great work!

Jason

@JasonMrX
Copy link
Author

@AArnott who originally added support for reference exclusion. Thanks!

@AArnott
Copy link
Contributor

AArnott commented Nov 26, 2018

This project isn't maintained by its original owners any more (myself included). We encourage folks to use .NET SDK self-packaging projects or other more modern methods. NuProj is quite old compared to the latest NuGet and csproj standards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants