add bookmark dialog for firefox with latest NVDA next branch not working correctly

[nvaccessAuto]

Reported by dallasobrien on 2014-02-20 04:51
I am using Firefox version 27.0.1, with next snapshot Version: next-10380,9ee9b11
The add bookmark dialog appears to not be able to gain focus correctly. it says the name of the page, but then you can not tab through the dialog. I have tested the main release, as well as master, and these work correctly. it appears to be a change in the latest versions of NVDA next.
object navigation lets you see the window, with the name field, and buttons and other such elements, but normal actions such as tabbing, or using the arrow keys don't seem to work.

Blocking #3831

[nvaccessAuto]

Comment 1 by mdcurran on 2014-02-20 05:48
Regression caused by #3831. The Add Bookmarks window appears before the foreground window in z order, but does not seem to be top most as it appears after Explorer's taskbar etc.

[nvaccessAuto]

Comment 2 by jteh on 2014-02-20 05:57
Damn it. Did you check whether it has WS_POPUP by any chance?

[nvaccessAuto]

Comment 3 by mdcurran (in reply to comment 2) on 2014-02-20 06:05
Replying to jteh:
Looks like it does have WS_POPUP... at least its root anyway.

[nvaccessAuto]

Comment 4 by briang1 on 2014-02-20 11:30
In case its not clear, the same effect is also happening on Windows XP as well, so I guess its generic.

[nvaccessAuto]

Comment 6 by James Teh <jamie@... on 2014-02-22 08:50
In [7935e8f]:

Stop ignoring the Firefox Page Bookmarked window, OpenOffice/LibreOffice context menus and possibly other cases.

In eventHandler.shouldAcceptEvent, as well as testing whether the window is a descendant of the foreground window, also check whether it's root owner is a descendant of the foreground.
Re #3899, #3905.

[nvaccessAuto]

Comment 7 by James Teh <jamie@... on 2014-02-22 08:50
In [e55984b]:

Merge branch 't3831' into next

Incubates #3831. Fixes #3899, #3905.

Changes:
State: closed

[nvaccessAuto]

Comment 8 by Ahiiron on 2014-02-22 10:25
Nice, confirmed fixed in next-10391,e55984b