Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe incorrectly interpreted as a word separator #4607

Closed
nvaccessAuto opened this issue Nov 7, 2014 · 8 comments
Closed

Apostrophe incorrectly interpreted as a word separator #4607

nvaccessAuto opened this issue Nov 7, 2014 · 8 comments

Comments

@nvaccessAuto
Copy link

Reported by leonarddr on 2014-11-07 11:48
The change in #1704 does not yet work for combinations containing apostrophes. I have "'t" which should be pronounced as het, In combination such as "don't", the dictionary item does apply although whole word is selected. IN other words, the apostrophe is detected as a word separator. This is also visible when speak typed words is on:
Input: kb(laptop):d IO - inputCore.InputManager.executeGesture (12:45:50): Input: kb(laptop):o IO - inputCore.InputManager.executeGesture (12:45:50): Input: kb(laptop):n IO - inputCore.InputManager.executeGesture (12:45:50): Input: kb(laptop):ACUTE/CEDILLA IO - inputCore.InputManager.executeGesture (12:45:51): Input: kb(laptop):t IO - speech.speakTypedCharacters (12:45:51): typed word: don IO - speech.speak (12:45:51): Speaking [u'don']

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2014-11-12 04:31
Can you explain why you want "'t" to be considered a word? I understand that apostrophe in the middle of a word is still part of the word, but apostrophe at the start of a word isn't part of the word. Even if we made sure "don" didn't match in "don't", that wouldn't fix your case.

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2014-11-12 04:48
Technical: regular expression to match "don" or "don'", but not "don't", "don's", etc.:

\bdon(?:(?='(?:\W|$))|(?![\w']))

@nvaccessAuto
Copy link
Author

Comment 3 by leonarddr on 2014-11-12 07:38
"'t" is a shorthand synonym for the dutch word "het". Also, "'m" stands foor "hem". If you dislike the idea i propose in this ticket, it could also be considered to fix the issue of pronouncing letters preceded by apostrophes in the right way in the Dutch language. I could start a separate ticket for that if you wish.

@nvaccessAuto
Copy link
Author

Comment 4 by blindbhavya on 2014-11-12 16:07
Hi,
I am not 100% sure if the following is related to this ticket, by the summary line I feel it is:
Question: Is word navigation (Ctrl + left/right arrows) handled by NVDA, or are they application specific shortcut keys?
If NVDA handles them, then read the following word:
don't
If you read the above line word by word, then don' is considered one word, and t as the second word.
Question: Is this an NVDA issue?
If yes, then is it covered in this ticket itself?
If yes, should I file another ticket for this issue, or does one exist?

@nvaccessAuto
Copy link
Author

Comment 5 by jteh (in reply to comment 4) on 2014-11-12 22:03
Replying to blindbhavya:

Question: Is word navigation (Ctrl + left/right arrows) handled by NVDA, or are they application specific shortcut keys?

Application specific.

@nvaccessAuto
Copy link
Author

Comment 6 by jteh on 2014-11-19 04:39
Thanks for the info in comment:3. Based on that, I think we do need to do something, but I'm worried about issues with single quotes, which are often represented by the apostrophe character. Words preceded by single quotes should still match a word, but this conflicts with this request.

@LeonarddeR
Copy link
Collaborator

Note that #4622 fixed my use case for using apostrophes in speech dictionaries.

@jcsteh
Copy link
Contributor

jcsteh commented Jul 10, 2017

Closing because the original use case was handled another way and fixing this would break matching with single quotes (as per #4607 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants