Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reported background pattern labels don't match with the patterns in Excel 2016 #6092

Closed
LeonarddeR opened this issue Jun 18, 2016 · 2 comments
Closed

Reported background pattern labels don't match with the patterns in Excel 2016 #6092

LeonarddeR opened this issue Jun 18, 2016 · 2 comments
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
2016.3

Comments

@LeonarddeR
Copy link
Collaborator

NVDA reports Excel background patterns thanks to #3683. I've been looking into this to translate the patterns, and I noticed that the pattern names aren't in line with the names given in Excel 2016. For example:

  • 12,5% gray is reported as background pattern gray16
  • Reverse Diagonal Stripe is reported as background pattern down
  • Thick Diagonal Crosshatch is reported as semigray75

Especially the latter two make absolutely no sense to me. Since #3683 is closed and included in 2016.2, I thought it would be best to report this in a new issue here.
@jcsteh
Copy link
Contributor

jcsteh commented Jun 23, 2016

@ManshulBelani, could you look into this please? CC @dineshkaushal.

@ManshulBelani ManshulBelani mentioned this issue Jul 5, 2016
Merged
@nvaccessAuto nvaccessAuto added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 5, 2016
michaelDCurran pushed a commit that referenced this issue Jul 24, 2016
@ManshulBelani @michaelDCurran
In Microsoft Excel, the background pattern names reported by NVDA now…
3c0860a 
… match those used by Excel. Fixes #6092.
@josephsl
Copy link
Collaborator

josephsl commented Aug 2, 2016

Reopening due to a major regression found:

@ManshulBelani, It seems background text is causing issues for translators, in that .po cannot be compiled into .mo.

Thanks.

@josephsl josephsl reopened this Aug 2, 2016
@josephsl josephsl mentioned this issue Aug 2, 2016
Closed
@jcsteh jcsteh mentioned this issue Aug 8, 2016
Merged
@jcsteh jcsteh added this to the 2016.3 milestone Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
2016.3
Development

No branches or pull requests
4 participants
@LeonarddeR @jcsteh @josephsl @nvaccessAuto