Initial support for the upcoming version of the Kindle app #6247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y methods to be abstract enough to not have to specifically handle _rangeObj. _rangeObj only exists for certain TextInfos (UIA, MS Word, MSHTML) but not IA2Text etc.
…tStart which just returns the NVDAObject the TextInfo is for (obj).
…_getNVDAObjectFromOffset which returns the NVDAObject the textInfo is for, and _getOffsetFromNVDAObject which if given the textInfo's object, returns the offset from 0 to story length.
…d role is silenced on focus).
…an MSAA role of client and a sysmenu should not be enough to force this to True. Rather it should also have event_objectID of client and a childID of 0, explicitly meaning this is the client root of the window.
… if the object implements DocumentWithPageTurns.
…t not ReviewTextInfoRegion.
Specifically: * Browse mode allowing for moving through the content by character, word, line etc with the arrow keys. * Automatic page turns when reaching the start/end of a page with the arrow keys / Say All. * Automatic reporting of page labels or numbers if available * Reporting of current location within a book (including percentage) via NVDA's report location command (NVDA+numpadDelete).
…ed state is not correctly set.
…le of contents treeview).
…: only detect possible selection changes if there is no pending focus event. Some frameworks such as QT clear the selection in an edit field before moving focus away.
…ed to QT5. qt.Container: shouldAllowIAccessibleFocusEvent should always be true if there is an activeChild. QT5 does not set the focused state on the list or an ancestor in this instance. correct.
| @@ -1300,7 +1300,7 @@ def event_selectionWithIn(self): | |||
|
|
|||
| def _get_isPresentableFocusAncestor(self): | |||
| IARole = self.IAccessibleRole | |||
| if IARole == oleacc.ROLE_SYSTEM_CLIENT and self.windowStyle & winUser.WS_SYSMENU: | |||
| if IARole == oleacc.ROLE_SYSTEM_CLIENT and self.event_objectID==winUser.OBJID_CLIENT and self.event_childID==0 and self.windowStyle & winUser.WS_SYSMENU: | |||
There was a problem hiding this comment.
I think we should have a comment in this block explaining this, as it's a bit obscure. Something like this:
# This is the root object of a top level window.
# #4300: We check the object and child ids as well because there can be "clients" other than the root.
… be overwritten again. Als ensure that WordDocumentTextInfo can be copied via passing another TextInfo as its constructor.
|
Hi Mic: |
|
It's not released yet. No estimated release date has been given.
|
jcsteh
added a commit
that referenced
this pull request
Dec 2, 2016
… Kindle app. The version of Kindle supported by this code will not be released. Instead, a later version will be released with more features, but this also requires newer NVDA code which will not be included as part of this release. This older NVDA code won't cause any major problems, but it won't work as expected. Therefore, we shouldn't mention this in the What's New, but there's no need to remove the code at this late stage. Re #6247.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
* Browse mode allowing for moving through the content by character, word, line etc with the arrow keys.
* Automatic page turns when reaching the start/end of a page with the arrow keys / Say All.
* Automatic reporting of page labels or numbers if available
* Reporting of current location within a book (including percentage) via NVDA's report location command (NVDA+numpadDelete).
This PR contains various small changes to treeInterceptors and textInfos,handling page turns in braille, and fixes for QT5. Fixes #4300.