Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary import in api.py #7389

Closed
dkager opened this issue Jul 12, 2017 · 3 comments
Closed

Unnecessary import in api.py #7389

dkager opened this issue Jul 12, 2017 · 3 comments
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
2017.3

Comments

@dkager
Copy link
Collaborator

dkager commented Jul 12, 2017

The braille module is imported in setReviewPosition but is also globally imported at the top of the file. The function-specific one is redundant. Or if it's not, a line of documentation would be nice to explain this.
@jcsteh
Copy link
Contributor

jcsteh commented Jul 12, 2017

Nope, the function specific import is redundant and can be removed.

@jcsteh jcsteh added the p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 12, 2017
@dkager
Copy link
Collaborator Author

dkager commented Jul 13, 2017

Do you want a PR or can you sneak in a quick commit? :)

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Jul 13, 2017 via email

@dkager dkager mentioned this issue Jul 16, 2017
Merged
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
2017.3
Development

No branches or pull requests
4 participants
@LeonarddeR @dkager @jcsteh @nvaccessAuto