Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label is announced twice for role="checkbox" instances #7948

Closed
peasandwell opened this issue Jan 31, 2018 · 8 comments
Closed

Label is announced twice for role="checkbox" instances #7948

peasandwell opened this issue Jan 31, 2018 · 8 comments
Labels
app/internet-explorer bug/double-speaking bug close/worksforme p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@peasandwell
Copy link

Steps to reproduce:

  1. Open IE11
  2. Browse to https://codepen.io/peasandwell/pen/oEXorY
  3. Focus onto custom checkbox
  4. Notice label is announced twice

Expected behavior:

Label should be announced once, as it would in Firefox.

Actual behavior:

The label for the custom checkbox is announced twice (i.e. Lorem ipsum Lorem ipsum checkbox not checked")

System configuration:

NVDA version: 2017.4 on Windows 10, tested on IE11.
@feerrenrut
Copy link
Contributor

I can reproduce this with the provided codepen I got the following results:

  • IE11 speaks twice
  • Chrome speaks twice
  • Firefox speaks once
  • Edge speaks once

@feerrenrut feerrenrut added bug p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority app/chrome app/internet-explorer and removed app/internet-explorer labels Feb 5, 2018
@feerrenrut feerrenrut mentioned this issue Feb 6, 2018
Closed
@feerrenrut
Copy link
Contributor

Unlike #7960 this issue also affects 2017.3

@nhaidaraly
Copy link

The issue is still present on IE11 but was solved on Chrome, Firefox and Edge...

@DiegoBM
Copy link

DiegoBM commented Mar 5, 2019 •
edited

I can reproduce this issue in Chrome consistently
NVDA version: 2018.4.1

@DiegoBM
Copy link

DiegoBM commented Mar 6, 2019

It also happens for native check-boxes by the way, not just custom ones.

This issue is dating back January last year and nobody has worked on it on more than one year, is it something that was agreed to stay as it is?

@Adriani90
Copy link
Collaborator

cc: @LeonarddeR, @jcsteh

@Zacqary Zacqary mentioned this issue Jul 31, 2019
Closed
@Adriani90
Copy link
Collaborator

@feerrenrut could this also be a duplicate of #9155?

aarongable pushed a commit to chromium/chromium that referenced this issue Sep 6, 2019
Devtools: making the rendering tool accessible + adding rendering pag…
94b15fa 
…e to axe tests

Changes:
	- Added label to 'Emulate CSS media' combobox

Screen Reader on Rendering Page:
        - https://imgur.com/YsTeXiW

SR reading label twice bug present in this tool's checkboxes:
        - nvaccess/nvda#7948
        - nvaccess/nvda#8885

Bug: 963183
Change-Id: I4711ef42b573f62770fb64b237077de5d20ee06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656733
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694324}
devtools-bot pushed a commit to ChromeDevTools/devtools-frontend that referenced this issue Sep 6, 2019
Devtools: making the rendering tool accessible + adding rendering pag…
be2a1f6 
…e to axe tests

Changes:
	- Added label to 'Emulate CSS media' combobox

Screen Reader on Rendering Page:
        - https://imgur.com/YsTeXiW

SR reading label twice bug present in this tool's checkboxes:
        - nvaccess/nvda#7948
        - nvaccess/nvda#8885

Bug: 963183
Change-Id: I4711ef42b573f62770fb64b237077de5d20ee06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656733
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#694324}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 94b15fab94256e154f9b2cad007da201e06071ea
babot pushed a commit to binaryage/dirac that referenced this issue Sep 7, 2019
Devtools: making the rendering tool accessible + adding rendering pag…
81e5271 
…e to axe tests

Changes:
	- Added label to 'Emulate CSS media' combobox

Screen Reader on Rendering Page:
        - https://imgur.com/YsTeXiW

SR reading label twice bug present in this tool's checkboxes:
        - nvaccess/nvda#7948
        - nvaccess/nvda#8885

Bug: 963183
Change-Id: I4711ef42b573f62770fb64b237077de5d20ee06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656733
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694324}
@Adriani90 Adriani90 mentioned this issue Dec 20, 2019
Closed
@Adriani90
Copy link
Collaborator

Closing as fixed, in Chrome and Edge 112 as well as Firefox 111 when focusing the checkbox either in focus or in browse mode, NVDA speaks the checkbox only once.
If you still have this issue, please comment with updated steps to reproduce and we can reopen.
Note that support for IE ended in 2022 completely and it is automatically removed from machines that still have it after an Edge update in February 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/internet-explorer bug/double-speaking bug close/worksforme p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@DiegoBM @feerrenrut @peasandwell @ehollig @Adriani90 @nhaidaraly