Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with pytest 8 #1438

Open
frenzymadness opened this issue Apr 11, 2024 · 0 comments
Open

Compatibility with pytest 8 #1438

frenzymadness opened this issue Apr 11, 2024 · 0 comments

Comments

@frenzymadness
Copy link

I'm not yet sure why but when I run tests with pytest 8, 4 of them fail:

========================================= FAILURES ==========================================
_ TestGetValidHistoryWithoutCurrent.test_get_valid_history_without_current[le cat-result0] __

self = <tests.test_utils.TestGetValidHistoryWithoutCurrent object at 0x7fa5c8fc9e20>
script = 'le cat', result = ['ls cat', 'diff x', 'café ô']

    @pytest.mark.parametrize('script, result', [
        ('le cat', ['ls cat', 'diff x', u'café ô']),
        ('diff x', ['ls cat', u'café ô']),
        ('fuck', ['ls cat', 'diff x', u'café ô']),
        (u'cafe ô', ['ls cat', 'diff x', u'café ô']),
    ])
    def test_get_valid_history_without_current(self, script, result):
        command = Command(script, '')
>       assert get_valid_history_without_current(command) == result
E       AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x', 'café ô']
E         
E         Right contains one more item: 'café ô'
E         
E         Full diff:
E           [
E               'ls cat',
E               'diff x',
E         -     'café ô',
E           ]

/home/lbalhar/Software/thefuck/tests/test_utils.py:276: AssertionError
_ TestGetValidHistoryWithoutCurrent.test_get_valid_history_without_current[diff x-result1] __

self = <tests.test_utils.TestGetValidHistoryWithoutCurrent object at 0x7fa5c8fca030>
script = 'diff x', result = ['ls cat', 'café ô']

    @pytest.mark.parametrize('script, result', [
        ('le cat', ['ls cat', 'diff x', u'café ô']),
        ('diff x', ['ls cat', u'café ô']),
        ('fuck', ['ls cat', 'diff x', u'café ô']),
        (u'cafe ô', ['ls cat', 'diff x', u'café ô']),
    ])
    def test_get_valid_history_without_current(self, script, result):
        command = Command(script, '')
>       assert get_valid_history_without_current(command) == result
E       AssertionError: assert ['ls cat'] == ['ls cat', 'café ô']
E         
E         Right contains one more item: 'café ô'
E         
E         Full diff:
E           [
E               'ls cat',
E         -     'café ô',
E           ]

/home/lbalhar/Software/thefuck/tests/test_utils.py:276: AssertionError
__ TestGetValidHistoryWithoutCurrent.test_get_valid_history_without_current[fuck-result2] ___

self = <tests.test_utils.TestGetValidHistoryWithoutCurrent object at 0x7fa5c8fca0f0>
script = 'fuck', result = ['ls cat', 'diff x', 'café ô']

    @pytest.mark.parametrize('script, result', [
        ('le cat', ['ls cat', 'diff x', u'café ô']),
        ('diff x', ['ls cat', u'café ô']),
        ('fuck', ['ls cat', 'diff x', u'café ô']),
        (u'cafe ô', ['ls cat', 'diff x', u'café ô']),
    ])
    def test_get_valid_history_without_current(self, script, result):
        command = Command(script, '')
>       assert get_valid_history_without_current(command) == result
E       AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x', 'café ô']
E         
E         Right contains one more item: 'café ô'
E         
E         Full diff:
E           [
E               'ls cat',
E               'diff x',
E         -     'café ô',
E           ]

/home/lbalhar/Software/thefuck/tests/test_utils.py:276: AssertionError
_ TestGetValidHistoryWithoutCurrent.test_get_valid_history_without_current[cafe \xf4-result3] _

self = <tests.test_utils.TestGetValidHistoryWithoutCurrent object at 0x7fa5c9070110>
script = 'cafe ô', result = ['ls cat', 'diff x', 'café ô']

    @pytest.mark.parametrize('script, result', [
        ('le cat', ['ls cat', 'diff x', u'café ô']),
        ('diff x', ['ls cat', u'café ô']),
        ('fuck', ['ls cat', 'diff x', u'café ô']),
        (u'cafe ô', ['ls cat', 'diff x', u'café ô']),
    ])
    def test_get_valid_history_without_current(self, script, result):
        command = Command(script, '')
>       assert get_valid_history_without_current(command) == result
E       AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x', 'café ô']
E         
E         Right contains one more item: 'café ô'
E         
E         Full diff:
E           [
E               'ls cat',
E               'diff x',
E         -     'café ô',
E           ]

/home/lbalhar/Software/thefuck/tests/test_utils.py:276: AssertionError

There are some known breaking changes in pytest 8 but I'm not sure which one causes this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant