Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue tracker for Full GNOME 46 support #271

Open
3 of 4 tasks
Totto16 opened this issue Mar 30, 2024 · 28 comments
Open
3 of 4 tasks

Issue tracker for Full GNOME 46 support #271

Totto16 opened this issue Mar 30, 2024 · 28 comments
Assignees
Labels
enhancement New feature or request Priority High Priority High

Comments

@Totto16
Copy link
Collaborator

Totto16 commented Mar 30, 2024

Since #264 adds support for gnome 46 it should be good in terms of GJS changes, but while working on #265 I noticed some changes in the gnome-shell UI libraries, we also use. There are some changes that I, and presumably others didn't notice, since e.g. Source from here doesn't have showNotification anymore since GNOME 46, but it's called addNotification. But the types suggested it before, so while fixing types over at https://github.com/gjsify/gnome-shell we should check, if we need to change more types to check for gnome 45 / 46 compatibility at runtime.

Task list:

Optional:

@Totto16 Totto16 added the enhancement New feature or request label Mar 30, 2024
@Totto16 Totto16 self-assigned this Mar 30, 2024
@Totto16 Totto16 added the Priority High Priority High label Mar 30, 2024
@RushingAlien
Copy link

I would like to add that due to direct scanout for full screen windows under Wayland, pano will fail do display when a window is fullscreen, the solution for this is using Meta.disable_unredirect_for_display() when the pano dialog/panel pops up. References on how to do this can be found in G-dH/window-thumbnails@bb87507 and icedman/search-light@25b43ea.

This is only needed until GNOME supports overlay planes which will allow layered and non-fullscreen direct scanout.

Note from window-thumbnail dev about disable_unredirect: G-dH/window-thumbnails#7 (comment)

@Totto16
Copy link
Collaborator Author

Totto16 commented Apr 1, 2024

I would like to add that due to direct scanout for full screen windows under Wayland, pano will fail do display when a window is fullscreen, the solution for this is using Meta.disable_unredirect_for_display() when the pano dialog/panel pops up. References on how to do this can be found in G-dH/window-thumbnails@bb87507 and icedman/search-light@25b43ea.

This is only needed until GNOME supports overlay planes which will allow layered and non-fullscreen direct scanout.

Note from window-thumbnail dev about disable_unredirect: G-dH/window-thumbnails#7 (comment)

Thanks for the suggestion 👍🏼 I will test that and also fix it 👍🏼

@marcinjahn
Copy link

@Totto16 The README mentions Gnome 46 as being supported, while EGO is still on Gnome 45. I assume that I could just get the latest zip from Releases and it will work on G46, right? It seems that the only "issue" there is highlight.js still being embedded.

@Totto16
Copy link
Collaborator Author

Totto16 commented May 3, 2024

@marcinjahn Correct, the "issue" with highlight.js is, that EGO doesn't want to have that too much third party dependencies in published extensions. So The master branch fully supports GNOME 46, but for a release on EGO I have to complete #278 (which might take some time).

To install it locally, follow the steps here

You have to download the latest files from the master branch tough, the latest release doesn't support gnome 46 yet and we didn't make a new release yet 😓

@marcinjahn
Copy link

Sure, thanks for the clarification!

@theGeekyLad
Copy link

Does this issue also pertain to GNOME 46.1 (currently breaking)?

@Totto16
Copy link
Collaborator Author

Totto16 commented May 5, 2024

Does this issue also pertain to GNOME 46.1 (currently breaking)?

Not really, this is mainly for Gnome 46.0 support (and the EGO release for that) .

That said, just open a new issue with the exact details and I'll look into it separately. The EGO topic might take a while.
But fixing compatibility for gnome 46.1 would take a higher priority.

This is really interesting, since minor releases shouldn't break anything, but I'm not surprised, gnome 45.3 broke some things too 🤦🏼‍♂️

@oae
Copy link
Owner

oae commented May 6, 2024

I tested the master branch on 46.1 and saw no issues.

@Totto16
Copy link
Collaborator Author

Totto16 commented May 6, 2024

I tested the master branch on 46.1 and saw no issues.

Interesting, then he probably meant the public EGO release 😓
Or am I wrong @theGeekyLad

@talesam
Copy link
Contributor

talesam commented May 9, 2024

Testei a filial principal em 46.1 e não vi problemas.

I am one of the Biglinux Devs and I take care of the Gnome version, it is on 46.1 and is based on Manjaro and it is not working, it says that the extension is not compatible with version 46.1

@Totto16
Copy link
Collaborator Author

Totto16 commented May 9, 2024

Testei a filial principal em 46.1 e não vi problemas.

I am one of the Biglinux Devs and I take care of the Gnome version, it is on 46.1 and is based on Manjaro and it is not working, it says that the extension is not compatible with version 46.1

The version on EGO doesn't yet support 46 due to some concern on some third party libraries from the side of the EGO reviewers, we are working on that, see #278

but you can self "compile" (transpile) the master branch and than it works

@Malix-off
Copy link

Is there an ETA as of when pano will be available for Gnome 46 ?

@Totto16
Copy link
Collaborator Author

Totto16 commented May 20, 2024

Is there an ETA as of when pano will be available for Gnome 46 ?

I have started to do the needed work, quite a while ago, (see #278 ) but I had some "more important" things to do, so I didn't have time for quite a while, I can use the extension by self building it so it also climbed down my priority list 😓 (which is kinda egostic and not a good excuse 😓 ).

I see that there is "high" demand and that Gnome 46 is out on many distros for a while (almost a month on Ubuntu, Fedora etc.)
So I am trying my best to schedule the needed work for as soon as possible 😓

@logicito
Copy link

Is there an ETA as of when pano will be available for Gnome 46 ?

I have started to do the needed work, quite a while ago, (see #278 ) but I had some "more important" things to do, so I didn't have time for quite a while, I can use the extension by self building it so it also climbed down my priority list 😓 (which is kinda egostic and not a good excuse 😓 ).

I see that there is "high" demand and that Gnome 46 is out on many distros for a while (almost a month on Ubuntu, Fedora etc.) So I am trying my best to schedule the needed work for as soon as possible 😓

Thank you very much, there is no better clipboard manager than Pano

@daethlor
Copy link

@marcinjahn Correct, the "issue" with highlight.js is, that EGO doesn't want to have that too much third party dependencies in published extensions. So The master branch fully supports GNOME 46, but for a release on EGO I have to complete #278 (which might take some time).

To install it locally, follow the steps here

You have to download the latest files from the master branch tough, the latest release doesn't support gnome 46 yet and we didn't make a new release yet 😓

On 24.04, when trying to self build I get:

00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'install'
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'build'

Would love to have even partial usability on 24.04 at this point.

@back-lacking
Copy link

is there an eta on gnome 45/46 support or is it currently still unknown?

@Totto16 Totto16 pinned this issue Jun 2, 2024
@Totto16
Copy link
Collaborator Author

Totto16 commented Jun 2, 2024

I published a pre-release, that has to be installed manually, but at least you don't need to self-built the extension.
Until I finally fix everything, and we can release it on EGO, it might take a while😓

@7system7
Copy link

7system7 commented Jun 2, 2024

OMG. This extension is (sadly) irreplaceable. Thank you.

@johnstonesnow
Copy link

I published a pre-release, that has to be installed manually, but at least you don't need to self-built the extension. Until I finally fix everything, and we can release it on EGO, it might take a while😓

Hi, is there any chance someone could explain how to install it please? I am on Fedora 40 and lost without Pano. thanks

@Vinnl
Copy link

Vinnl commented Jun 4, 2024

@johnstonesnow Information about the prelease can be found here.

From that page, download pano@elhan.io.zip. Open Files, click the path bar at the top and enter ~/.local/share/gnome-shell/extensions/ and press Enter. Copy the downloaded file into that folder, then open it to extract its contents into that folder. Next time you login, the extension should work.

@johnstonesnow
Copy link

Thanks very much.
Just to check, are you sure about that location? I went to it in FIles and I wonder if I need to go a level deeper, to put the extracted contents into the pano folder itself, can you confirm please? here's what I have in that folder string you gave me...

image

@Vinnl
Copy link

Vinnl commented Jun 4, 2024

@johnstonesnow Ah yes, that's the old version of Pano that's still installed - extracting the .zip will give you a new version of that folder. You can rename or delete the existing one, or alternatively, first uninstall the existing extension before following the steps I outlined above.

@johnstonesnow
Copy link

Ah, great thanks.
Forgive my ignorance, but if I uninstall the old one (not even sure how but will look that up), wont I need to install the new one? I was under the impression this was just a patch to fix a current installation,maybe its a full manual installation?
thanks again

@Vinnl
Copy link

Vinnl commented Jun 4, 2024

It is indeed a full manual installation - extracting the .zip into that directory is installing it (the prerelease).

@johnstonesnow
Copy link

Great, will give it a whirl. thanks

@johnstonesnow
Copy link

PS Just had a thought. I am thinking of trying out KDE Plasma DE on Fedora. I have never used it, fairly new to Linux overall. Am I right in thinking, if i were to switch to KDE, Pano will probably work (as it seems the issue is with Gnome DE)?
thanks

@logicito
Copy link

logicito commented Jun 4, 2024

PS Just had a thought. I am thinking of trying out KDE Plasma DE on Fedora. I have never used it, fairly new to Linux overall. Am I right in thinking, if i were to switch to KDE, Pano will probably work (as it seems the issue is with Gnome DE)? thanks

Pano is a Gnome extension, it only works with Gnome

@Totto16
Copy link
Collaborator Author

Totto16 commented Jun 4, 2024

PS Just had a thought. I am thinking of trying out KDE Plasma DE on Fedora. I have never used it, fairly new to Linux overall. Am I right in thinking, if i were to switch to KDE, Pano will probably work (as it seems the issue is with Gnome DE)? thanks

No, Pano only works with Gnome. KDE is another DE (Desktop Environment).
Pano is a gnome extension and therefore only works with Gnome. It also uses a lot of Gnome specific features and on KDE there are other clipboard managers that you can use 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority High Priority High
Projects
None yet
Development

No branches or pull requests