Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview detection uses wrong version number #174

Open
oalders opened this issue Feb 5, 2020 · 0 comments
Open

Webview detection uses wrong version number #174

oalders opened this issue Feb 5, 2020 · 0 comments

Comments

@oalders
Copy link
Owner

oalders commented Feb 5, 2020

As reported by email:

the pattern matching for webview detection, lines 974-978. In this code block you're matching anything that's chrome + android + version 30.0 or greater. This isn't correct, according to the Google link in the documentation (See: https://developer.chrome.com/multidevice/user-agent#webview_user_agent ), the version number should not be included in the pattern matching but rather the Version/_X.X string. So rather than matching browser_major > 30, it should be a pattern match for the presence of Version/_X.X.

Using the code as-is, all android hits that are version 30.0 or greater are being reported as android - webview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant