Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build before replacing? #950

Closed
Fil opened this issue Mar 2, 2024 · 2 comments
Closed

build before replacing? #950

Fil opened this issue Mar 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented Mar 2, 2024

We should build in build-current/, then on success “atomically” rename build/ to build-old/ and build-current to build, and finally rimraf build-old/. This would help to compare a broken build to the previous run. I would also ensure that a build is served locally without interruption, for workflows where it makes sense to do so (like sharing with ngrok or some such).

@Fil Fil added the enhancement New feature or request label Mar 2, 2024
@mbostock
Copy link
Member

mbostock commented Mar 2, 2024

Do you mean just in our repo, or do you mean observable build in general? The former should be readily doable, but the latter would be a fairly significant API change since we don’t do clean builds — people could already rely on the fact that we only add files to the giving dist folder and preserve what’s already there.

@Fil
Copy link
Contributor Author

Fil commented Mar 2, 2024

I meant for observable build in general, but I was confused as I was experiencing this situation in our repo while testing builds repeatedly. However, it's not needed in our repo, so let's do nothing. Thanks for the feedback!

@Fil Fil closed this as completed Mar 2, 2024
@Fil Fil changed the title build before replacing build before replacing? Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants