Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check validity of patches on opam lint --check-upstream #5886

Open
kit-ty-kate opened this issue Mar 19, 2024 · 0 comments
Open

Check validity of patches on opam lint --check-upstream #5886

kit-ty-kate opened this issue Mar 19, 2024 · 0 comments

Comments

@kit-ty-kate
Copy link
Member

#5400 changed the tool opam uses to apply patches. This break some of the patches present in opam-repository, whose format is corrupted. GNU patch seems to be more lenient with diff format errors, whereas git apply is more strict.

For example:

#=== ERROR while compiling easy-format.1.0.1 ==================================#
These patches didn't apply at /home/opam/.opam/4.14/.opam-switch/build/easy-format.1.0.1:
  - easy-format-make.diff: "/usr/bin/git -c core.autocrlf=false apply --unsafe-paths -p1 /home/opam/.opam/log/processed-patch-8-c2309c" exited with code 128 "error: corrupt patch at line 5"

One tool that might help us check the state of opam-repository more automatically could be opam lint --check-upstream if patch applications were checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant