Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the specification of frequency for hours in pandas data_range #1049

Merged
merged 5 commits into from
May 21, 2024

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Feb 8, 2024

Closes #1046

@fwitte
Copy link
Member Author

fwitte commented Feb 9, 2024

The create_time_index test now fails under python 3.8 and succeeds for python 3.9 and higher. And, if I understand the pandas future warning correctly, will fail once pandas 3.0 becomes available. So sometime soon python 3.8 support should be dropped, I think.

Copy link
Member

@p-snft p-snft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a required hotfix. Maybe, supporting different versions of Python is something for another PR.

.github/workflows/tox_pytests.yml Show resolved Hide resolved
@fwitte
Copy link
Member Author

fwitte commented May 21, 2024

What is the current state here? I am getting tired of the pandas warnings... :D

It's the current stable release, so we should support it.
@p-snft p-snft force-pushed the fix/#1046-pandas-date_range-future-warning branch from f4d26cb to 7bc2b30 Compare May 21, 2024 19:49
@p-snft
Copy link
Member

p-snft commented May 21, 2024

Feel free to merge. (Didn't manage to get GitHub to test using Python 3.12 but that is a separate issue.)

@fwitte fwitte merged commit b35efad into dev May 21, 2024
14 checks passed
@fwitte
Copy link
Member Author

fwitte commented May 21, 2024

Thank you, merged it!

@p-snft p-snft deleted the fix/#1046-pandas-date_range-future-warning branch May 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas gives a future warning for usage of "H" in a date_range
2 participants