Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Locale - translation #1179

Open
kleanthisk10 opened this issue Feb 20, 2021 · 15 comments
Open

Locale - translation #1179

kleanthisk10 opened this issue Feb 20, 2021 · 15 comments

Comments

@kleanthisk10
Copy link
Contributor

kleanthisk10 commented Feb 20, 2021

Hello,
I d like to add Greek translation to: http://gr-cities.survey.okfn.org/
I have added Greek translation here:
https://github.com/okfn/opendatasurvey/blob/master/census/locale/gr/LC_MESSAGES/messages.po

But it doesn't seem to work.
Is anything else that i should do?

I also need to translate the content (questions, datasets and places).

@roll
Copy link
Contributor

roll commented May 19, 2021

Hi @kleanthisk10,

Thanks for the effort. I tried a few times to fix and deploy translations and I had no luck. Now I raised this issue to our product team (cc @amercader @chris48s) so we will schedule this work if there enough resources as it doesn't seem to be a quick fix - something broken down the line.

@roll
Copy link
Contributor

roll commented Oct 12, 2021

Hi @kleanthisk10,

Good news! It seems we're back on track to being able to update translations. I've migrated the build pipeline to Github Actions and, currently, we can update messages.po and run make translate to update the codebase for a PR, and then I can deploy it.

http://gr-cities.survey.okfn.org/

PS.
To finish the translation it will be some back and forth adding new gettext calls to the code (if needed) and adding new msgid to the PO file. I can help with it, please PR as well

@kleanthisk10
Copy link
Contributor Author

Hello @roll
Thank you! Great news! I will update the messages.po and PR the changes!
There are some parts that didn't change e.g. http://gr-cities.survey.okfn.org/submit/?place=athens&dataset=spending
Is there anything I missed from translation?

@roll
Copy link
Contributor

roll commented Oct 13, 2021

Hi, it seems there are not a part of the standard translations. I can update them using another method.

Can you please add these strings to PO as well? Like:

msgid "Section A - About you"
msgstr "Section A - About you (gr)"

@kleanthisk10
Copy link
Contributor Author

Hello @roll I finished the missing translations #1180

@kleanthisk10
Copy link
Contributor Author

Hello @roll it seems that there are still some issues.
http://gr-cities.survey.okfn.org/submit/?place=athens&dataset=elections

I created a PR #1182 where i translated again yes/no. The other strings are already translated in messages.po but not appear in site.

@roll
Copy link
Contributor

roll commented Dec 2, 2021

Hi @kleanthisk10,

Thanks for the heads-up. I'll go through it on Monday

@roll
Copy link
Contributor

roll commented Dec 6, 2021

@kleanthisk10
Copy link
Contributor Author

no i can't

@roll
Copy link
Contributor

roll commented Dec 7, 2021

Hi @avdata99,

Maybe you can help us here?

@kleanthisk10
Copy link
Contributor Author

Hi @roll @avdata99 is it possible to be resolved by the end of the week?

@avdata99
Copy link
Member

Should we close this @roll ?

@roll
Copy link
Contributor

roll commented Dec 17, 2021

cc @kleanthisk10

@kleanthisk10
Copy link
Contributor Author

kleanthisk10 commented Dec 18, 2021

You did a a great job, thank you! We run the first workshops and we have more to complete the survey!
However there are some minor parts that didn 't turn into greek and i have included them in the translation PR.
You can see Section A e.g. here: http://gr-cities.survey.okfn.org/submit/?place=athens&dataset=elections

and also here http://gr-cities.survey.okfn.org/entry/komotini/spending/

How can we translate them? I think these are the last changes and we could close the issue.

@roll
Copy link
Contributor

roll commented Dec 20, 2021

Thanks, we will investigate after the break

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants