New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't open file to check if it exists #742

Closed

nddrylliog opened this issue Nov 29, 2013 · 1 comment

Assignees

Labels

Perf (rock) SDK

Milestone

Member

nddrylliog commented Nov 29, 2013

Solutions:

Use lstat on Linux: http://linux.die.net/man/2/stat
Use GetFileAttributes on Windows: http://blogs.msdn.com/b/oldnewthing/archive/2007/10/23/5612082.aspx

This'll allow shaving off a few milliseconds of rock compiles, for example:

ghost assigned nddrylliog

Member Author

nddrylliog commented Nov 29, 2013

(That's rock compiling something quite small, not rock compiling rock itself.)

nddrylliog added a commit that referenced this issue


          Don't open file to check if it exists + exists test. Closes #742

fc2b48b

nddrylliog closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment