Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't automatically create the 'instances' hashmap in CoverDecl #743

Closed
nddrylliog opened this issue Nov 29, 2013 · 1 comment
Closed

Don't automatically create the 'instances' hashmap in CoverDecl #743

nddrylliog opened this issue Nov 29, 2013 · 1 comment
Assignees
@nddrylliog
Labels
Code quality Middle-end Perf (rock)
Milestone
0.9.9

Comments

@nddrylliog
Copy link
Member

As it turns out, it's quite expensive... HashMap creates 100 buckets by default, on a 1.5s rock run, at least 36ms are spent in there, and they don't need to be.
@ghost ghost assigned nddrylliog Nov 29, 2013
@nddrylliog
Copy link
Member Author

Closed in 99x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nddrylliog nddrylliog

Labels
Code quality Middle-end Perf (rock)
Projects
None yet
Milestone
0.9.9
Development

No branches or pull requests
1 participant
@nddrylliog