Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date of final state change #1582

Closed
jpmckinney opened this issue Dec 20, 2022 · 3 comments · Fixed by #1683
Closed

Date of final state change #1582

jpmckinney opened this issue Dec 20, 2022 · 3 comments · Fixed by #1683
Assignees
Labels
Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Projects
Milestone

Comments

@jpmckinney
Copy link
Member

Splitting from #1160

Copying some discussion from CRM-8486.

A publisher wants to disclose the date on which the process reached its final state. This date might differ from the date on which the notice is published (date).

We can either have:

  1. One field for each state (dateCancelled and dateWithdrawn – presumably, dateUnsuccessful is not needed, as this occurs simultaneously with the tenderPeriod/endDate if there are no qualified bids)
  2. One field for the final state (since the final states are disjoint – i.e. a process can't be both cancelled and withdrawn, etc. – we only ever have one date to model). The field name would follow whatever name we choose for the status.

I would go with 2.

@jpmckinney jpmckinney added the Schema: Fields Relating to adding or deprecating fields in the JSON Schema label Dec 20, 2022
@jpmckinney jpmckinney added this to the 1.2.0 milestone Dec 20, 2022
@jpmckinney jpmckinney added this to To do in OCDS 1.2 via automation Dec 20, 2022
@duncandewhurst duncandewhurst self-assigned this Oct 9, 2023
@duncandewhurst duncandewhurst moved this from To do to In progress in OCDS 1.2 Oct 9, 2023
@duncandewhurst
Copy link
Contributor

To be done at the same time as #1583. Blocked until #1160 is done.

@duncandewhurst duncandewhurst added the blocked We can't merge this yet label Oct 12, 2023
@jpmckinney jpmckinney removed the blocked We can't merge this yet label Mar 27, 2024
@jpmckinney
Copy link
Member Author

Unblocked

@odscjen
Copy link
Contributor

odscjen commented Apr 3, 2024

Based on the advice given in the CRM issue, which was taking into account the new finalStatus fields in 1.2, we should use finalStatusDate as the single field name, an use this in every object that has a finalStatus field.

@odscjen odscjen moved this from In progress to Review in progress in OCDS 1.2 Apr 3, 2024
OCDS 1.2 automation moved this from Review in progress to Done May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Projects
OCDS 1.2
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants