Skip to content

Commit 080232a

Browse files
committed
Revert "MDIA: Bumped MDIA timeout value becasue of Nimbus DD1.0 workaround"
This reverts commit 7839e4d. Change-Id: Ic45b6e24b89871a287e9c191bd3603bade805901 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35618 Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com> Tested-by: Zane C. Shelley <zshelle@us.ibm.com>
1 parent 7839e4d commit 080232a

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

src/usr/diag/mdia/mdiasm.C

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,8 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
403403
// Committing an info log to help debug SW timeout
404404
if((*wit)->timeoutCnt >= MAINT_CMD_TIMEOUT_LOG)
405405
{
406-
MDIA_FAST("sm: committing a SW timeout info log "
407-
"for HUID:0x%08X", get_huid(target));
406+
MDIA_FAST("sm: committing a SW timed out info log "
407+
"for %x", get_huid(target));
408408

409409
/*@
410410
* @errortype
@@ -435,10 +435,9 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
435435
(*wit)->timeoutCnt++;
436436
}
437437

438-
MDIA_FAST("sm: work item %d reset SW timed out on "
439-
"HUID:0x%08X, timeoutCnt: %d",
440-
*((*wit)->workItem), get_huid(target),
441-
(*wit)->timeoutCnt);
438+
MDIA_FAST("sm: work item %d reset SW timed out on: %x, "
439+
"timeoutCnt: %d", *((*wit)->workItem),
440+
get_huid(target), (*wit)->timeoutCnt);
442441
// register a new timeout monitor
443442
uint64_t monitorId =
444443
getMonitor().addMonitor(MAINT_CMD_TIMEOUT);
@@ -473,7 +472,7 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
473472
HWAS::GARD_NULL);
474473

475474
// If maint cmd complete bit is not on, time out
476-
MDIA_FAST("sm: stopping command HUID:0x%08X", get_huid(target));
475+
MDIA_FAST("sm: stopping command: %p", target);
477476
//target type is MBA
478477
if ( TYPE_MBA == trgtType )
479478
{
@@ -536,8 +535,10 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
536535
wkflprop = *wit;
537536

538537
// log a timeout event
539-
MDIA_ERR("sm: workItem %d HW timeout on HUID:0x%08X",
540-
*((*wit)->workItem), get_huid(target));
538+
MDIA_ERR("sm: command %p: %d HW timed out on: %x",
539+
target,
540+
*((*wit)->workItem),
541+
get_huid(target));
541542

542543
errlCommit(timeoutErrl, MDIA_COMP_ID);
543544

@@ -745,7 +746,7 @@ bool StateMachine::scheduleWorkItem(WorkFlowProperties & i_wfp)
745746

746747
TargetHandle_t target = getTarget(i_wfp);
747748

748-
MDIA_FAST("sm: dispatching work item %d for: 0x%08x, priority: %d, "
749+
MDIA_FAST("sm: dispatching work item %d for: %p, priority: %d, "
749750
"unit: %d", *i_wfp.workItem,
750751
get_huid(target),
751752
priority,
@@ -801,7 +802,7 @@ bool StateMachine::executeWorkItem(WorkFlowProperties * i_wfp)
801802

802803
uint64_t workItem = *i_wfp->workItem;
803804

804-
MDIA_FAST("sm: executing work item %d for: 0x%08x",
805+
MDIA_FAST("sm: executing work item %d for: %x",
805806
workItem, get_huid(getTarget(*i_wfp)));
806807

807808
mutex_unlock(&iv_mutex);

src/usr/diag/mdia/mdiasm.H

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/* */
66
/* OpenPOWER HostBoot Project */
77
/* */
8-
/* Contributors Listed Below - COPYRIGHT 2012,2017 */
8+
/* Contributors Listed Below - COPYRIGHT 2012,2016 */
99
/* [+] International Business Machines Corp. */
1010
/* */
1111
/* */
@@ -41,11 +41,8 @@
4141
namespace MDIA
4242
{
4343

44-
// HW timeout value - 30 secs
45-
// Nimbus DD1.0 has a workaround that will go over 30 seconds. Will need to bump
46-
// it up for now. May consider lowering it later, but only if there is a
47-
// problem.
48-
static const uint64_t MAINT_CMD_TIMEOUT = 30000000000 * 10;
44+
//MBA timeout value - 30 secs
45+
static const uint64_t MAINT_CMD_TIMEOUT = 30000000000;
4946

5047
//Longer MBA timeout to be used when continuous tracing is enabled - 30 min
5148
static const uint64_t MAINT_CMD_TIMEOUT_LONG = 1800000000000;

0 commit comments

Comments
 (0)