Skip to content

Commit

Permalink
PRD: Allow clearing FIR bits on Unit Checkstops
Browse files Browse the repository at this point in the history
There is no planned support for unit checkstops in P9, so we don't
have any code in place for properly disabling checkstopped units.
It shouldn't matter, but when we get a bit mistakenly configured
as a Unit CS, we end up with a flood of errors for the uncleared
bit.

Change-Id: Ia7104b31c988434ca6df74889afad14c7ecd158b
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42613
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42635
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
  • Loading branch information
bweisenb authored and zane131 committed Jul 7, 2017
1 parent 29c37a0 commit 222af0c
Showing 1 changed file with 1 addition and 3 deletions.
Expand Up @@ -109,9 +109,7 @@ ResetAndMaskErrorRegister::Reset(const BitKey & bit_list,
{
int32_t rc = SUCCESS;
// Don't do reset on CS.
if ((CHECK_STOP != error.service_data->getPrimaryAttnType()) && //@pw01
(UNIT_CS != error.service_data->getPrimaryAttnType()) &&
(UNIT_CS != error.service_data->getSecondaryAttnType()))
if (CHECK_STOP != error.service_data->getPrimaryAttnType())
{
#ifndef __HOSTBOOT_MODULE
ServiceDataCollector & sdc = *(error.service_data);
Expand Down

0 comments on commit 222af0c

Please sign in to comment.