PRD: add more descriptive signatures to IPL targeted diags

Change-Id: Iad30a478d27b5799555672387979eb104921db9d
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38712
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38745
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>

Author: zane131

src/usr/diag/prdf/common/plat/mem/prdfP9McaExtraSig.H

@@ -28,6 +28,14 @@
 
 #include <prdrSignatures.H>
 
+PRDR_ERROR_SIGNATURE(StartVcmPhase1, 0xffff0000, "", "VCM: Starting phase 1");
+PRDR_ERROR_SIGNATURE(StartVcmPhase2, 0xffff0001, "", "VCM: Starting phase 2");
+PRDR_ERROR_SIGNATURE(StartDsdPhase1, 0xffff0002, "", "DSD: Starting phase 1");
+PRDR_ERROR_SIGNATURE(StartDsdPhase2, 0xffff0003, "", "DSD: Starting phase 2");
+PRDR_ERROR_SIGNATURE(StartTpsPhase1, 0xffff0004, "", "TPS: Starting phase 1");
+PRDR_ERROR_SIGNATURE(StartTpsPhase2, 0xffff0005, "", "TPS: Starting phase 2");
+PRDR_ERROR_SIGNATURE(EndTpsPhase2,   0xffff0006, "", "TPS: Phase 2 completed");
+
 PRDR_ERROR_SIGNATURE(MaintUE,        0xffff0010, "", "Maintenance UE");
 PRDR_ERROR_SIGNATURE(MaintIUE,       0xffff0011, "", "Maintenance IUE");
 PRDR_ERROR_SIGNATURE(MaintMPE,       0xffff0012, "", "Maintenance MPE");

src/usr/diag/prdf/plat/mem/prdfMemTps_ipl.C

@@ -62,17 +62,22 @@ uint32_t TpsEvent<TYPE_MCA>::nextStep( STEP_CODE_DATA_STRUCT & io_sc,
         //phase 0
         if ( TD_PHASE_0 == iv_phase )
         {
-            //start TPS phase 1
+            // Start TPS phase 1
+            io_sc.service_data->AddSignatureList( iv_chip->getTrgt(),
+                                                  PRDFSIG_StartTpsPhase1 );
+
             PRDF_TRAC( PRDF_FUNC "Starting TPS Phase 1" );
+
             o_rc = startTpsPhase1<TYPE_MCA>( iv_chip, iv_rank );
             if ( SUCCESS != o_rc )
             {
-                PRDF_ERR( PRDF_FUNC "Call to 'startTpsPhase1 failed on chip: "
-                          "0x%08x", iv_chip->getHuid() );
+                PRDF_ERR( PRDF_FUNC "startTpsPhase1(0x%08x,m%ds%d) failed",
+                          iv_chip->getHuid(), iv_rank.getMaster(),
+                          iv_rank.getSlave() );
                 break;
             }
-            iv_phase = TD_PHASE_1;
 
+            iv_phase = TD_PHASE_1;
         }
         //phase 1/2
         else
@@ -159,15 +164,21 @@ uint32_t TpsEvent<TYPE_MCA>::nextStep( STEP_CODE_DATA_STRUCT & io_sc,
                 //phase 1
                 if ( TD_PHASE_1 == iv_phase )
                 {
-                    //Start TPS phase 2
+                    // Start TPS phase 2
+                    io_sc.service_data->AddSignatureList( iv_chip->getTrgt(),
+                                                      PRDFSIG_StartTpsPhase2 );
+
                     PRDF_TRAC( PRDF_FUNC "Starting TPS Phase 2" );
+
                     o_rc = startTpsPhase2<TYPE_MCA>( iv_chip, iv_rank );
                     if ( SUCCESS != o_rc )
                     {
-                        PRDF_ERR( PRDF_FUNC "Call to 'startTpsPhase2 failed on "
-                                "chip: 0x%08x", iv_chip->getHuid() );
+                        PRDF_ERR( PRDF_FUNC "startTpsPhase2(0x%08x,m%ds%d) "
+                                  "failed", iv_chip->getHuid(),
+                                  iv_rank.getMaster(), iv_rank.getSlave() );
                         break;
                     }
+
                     iv_phase = TD_PHASE_2;
                 }
                 //phase 2

src/usr/diag/prdf/plat/mem/prdfMemVcm_ipl.C

@@ -59,15 +59,20 @@ uint32_t VcmEvent<TYPE_MCA>::nextStep( STEP_CODE_DATA_STRUCT & io_sc,
         //phase 0
         if ( TD_PHASE_0 == iv_phase )
         {
-            //start VCM phase 1
+            // Start VCM phase 1
+            io_sc.service_data->AddSignatureList( iv_chip->getTrgt(),
+                                                  PRDFSIG_StartVcmPhase1 );
+
             PRDF_TRAC( PRDF_FUNC "Starting VCM Phase 1" );
+
             o_rc = startVcmPhase1<TYPE_MCA>( iv_chip, iv_rank );
             if ( SUCCESS != o_rc )
             {
                 PRDF_ERR( PRDF_FUNC "startVcmPhase1(0x%08x, %d) failed",
                           iv_chip->getHuid(), iv_rank.getMaster() );
                 break;
             }
+
             iv_phase = TD_PHASE_1;
         }
         //phase 1
@@ -112,15 +117,20 @@ uint32_t VcmEvent<TYPE_MCA>::nextStep( STEP_CODE_DATA_STRUCT & io_sc,
             }
             else
             {
-                //Start VCM phase 2
+                // Start VCM phase 2
+                io_sc.service_data->AddSignatureList( iv_chip->getTrgt(),
+                                                      PRDFSIG_StartVcmPhase2 );
+
                 PRDF_TRAC( PRDF_FUNC "Starting VCM Phase 2" );
+
                 o_rc = startVcmPhase2<TYPE_MCA>( iv_chip, iv_rank );
                 if ( SUCCESS != o_rc )
                 {
-                    PRDF_ERR( PRDF_FUNC "Call to 'startVcmPhase2 failed on "
-                              "chip: 0x%08x", iv_chip->getHuid() );
+                    PRDF_ERR( PRDF_FUNC "startVcmPhase2(0x%08x, %d) failed",
+                              iv_chip->getHuid(), iv_rank.getMaster() );
                     break;
                 }
+
                 iv_phase = TD_PHASE_2;
             }
         }