Skip to content

Commit 3f21550

Browse files
stillgsdcrowell77
stillgs
authored and
dcrowell77
committed
PM: refine enablement attributes for advanced functions (VDM,RESCLK,WOF,IVRM)
- Move to a "disable feature" attribute paradigm for SYSTEM control - Add consistent system enablement (eg Cronus, MRW) control attributes - Added HWP attributes to allow p9_pstate_parameter_block to indicate validation status to p9_hcode_image_build for Hcode header updates - Mark attributes as deprecated for future removal - Added HB system defaults to auto enable RESCLK, VDM and WOF. IVRM is disabled. - RESCLK only has override attributes so will enable function once code that looks the attributes is in a driver - VDM enablement forces the need for #W to be there and valid. Valid will be if #W is all zero, disable VDMs; if any of #W is non-zerom, failing validity checks (non-decreasing VID Compares) will fail the IPL. - WOF enablement needs IQ to fill out the OCC parameter block. If not present, WOF is disabled. Longer term (future commit), RESCLKs and VDMs will also gate WOF but not for early development and testing. - Add a Chip EC attribute to discern the DD levels that WOF is supported - Move to IVRM vs IVRMS - Made all *ENABLED HWP attributes PROC_CHIP in scope to avoid collisions from multiple chip targets - Made all HWP attributes writeable - Deprecate (preped rename) an HWP attribute - Added throttle control attributes Change-Id: I5e56a36a9e2a4b3e6964ed66ff5c1013be26ed33 RTC: 173673 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40063 Dev-Ready: Gregory S. Still <stillgs@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael S. Floyd <mfloyd@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: CHRISTOPHER M. RIEDL <cmriedl@us.ibm.com> Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40089 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
1 parent 1b6b503 commit 3f21550

File tree

6 files changed

+744
-111
lines changed

6 files changed

+744
-111
lines changed

‎src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3619,8 +3619,24 @@
36193619
</chip>
36203620
</chipEcFeature>
36213621
</attribute>
3622-
3623-
<!-- ******************************************************************** -->
3622+
<!-- ******************************************************************** -->
3623+
<attribute>
3624+
<id>ATTR_CHIP_EC_FEATURE_WOF_NOT_SUPPORTED</id>
3625+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
3626+
<description>
3627+
Work Load Optimized Frequency non-support in manufacturing.
3628+
</description>
3629+
<chipEcFeature>
3630+
<chip>
3631+
<name>ENUM_ATTR_NAME_NIMBUS</name>
3632+
<ec>
3633+
<value>0x20</value>
3634+
<test>LESS_THAN</test>
3635+
</ec>
3636+
</chip>
3637+
</chipEcFeature>
3638+
</attribute>
3639+
<!-- ******************************************************************** -->
36243640
<attribute>
36253641
<id>ATTR_CHIP_EC_FEATURE_DD1_ANALOG</id>
36263642
<targetType>TARGET_TYPE_PROC_CHIP</targetType>

‎src/import/chips/p9/procedures/xml/attribute_info/pm_hwp_attributes.xml

Lines changed: 103 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<!-- -->
66
<!-- OpenPOWER HostBoot Project -->
77
<!-- -->
8-
<!-- Contributors Listed Below - COPYRIGHT 2016 -->
8+
<!-- Contributors Listed Below - COPYRIGHT 2016,2017 -->
99
<!-- [+] International Business Machines Corp. -->
1010
<!-- -->
1111
<!-- -->
@@ -327,4 +327,106 @@
327327
<writeable/>
328328
</attribute>
329329
<!-- ********************************************************************* -->
330+
<attribute>
331+
<id>ATTR_PSTATES_ENABLED</id>
332+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
333+
<description>Indicator that all relevant attributes and required data for
334+
Pstates to be enabled is present and valid
335+
336+
Producer: p9_build_pstate_datablock
337+
338+
Consumers: p9_pm_pstate_gpe_init
339+
</description>
340+
<valueType>uint8</valueType>
341+
<enum>FALSE=0, TRUE=1</enum>
342+
<writeable/>
343+
<initToZero/>
344+
</attribute>
345+
<!-- ********************************************************************* -->
346+
<attribute>
347+
<id>ATTR_RESCLK_ENABLED</id>
348+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
349+
<description>Indicator that all relevant attributes and required data for
350+
Resonant Clocking to be enabled is present and valid
351+
352+
Producer: p9_build_pstate_datablock
353+
354+
Consumers: p9_hcode_image_build ->
355+
PGPE Header
356+
CME Header
357+
</description>
358+
<valueType>uint8</valueType>
359+
<enum>FALSE=0, TRUE=1</enum>
360+
<writeable/>
361+
<initToZero/>
362+
</attribute>
363+
<!-- ********************************************************************* -->
364+
<attribute>
365+
<id>ATTR_VDM_ENABLED</id>
366+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
367+
<description>Indicator that all relevant attributes and required data for
368+
Voltage Droop Monitors (VDM) to be enabled is present and valid
369+
370+
Producer: p9_build_pstate_datablock
371+
372+
Consumers: p9_hcode_image_build ->
373+
SGPE Header
374+
CME Header
375+
</description>
376+
<valueType>uint8</valueType>
377+
<enum>FALSE=0, TRUE=1</enum>
378+
<writeable/>
379+
<initToZero/>
380+
</attribute>
381+
<!-- ********************************************************************* -->
382+
<attribute>
383+
<id>ATTR_IVRMS_ENABLED</id>
384+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
385+
<description>
386+
<!-- @todo RTC 173736 -->
387+
!!!!! Deprecated for ATTR_IVRM_ENABLED
388+
!!!!! Will be removed in the future
389+
</description>
390+
<valueType>uint8</valueType>
391+
<enum>FALSE=0, TRUE=1</enum>
392+
<writeable/>
393+
<initToZero/>
394+
</attribute>
395+
<!-- ********************************************************************* -->
396+
<attribute>
397+
<id>ATTR_IVRM_ENABLED</id>
398+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
399+
<description>Indicator that all relevant attributes and required data for
400+
Internal Voltage Regulator Macros (IVRMs) to be enabled is present and valid
401+
402+
Producer: p9_build_pstate_datablock
403+
404+
Consumers: p9_hcode_image_build ->
405+
PGPE Header
406+
CME Header
407+
</description>
408+
<valueType>uint8</valueType>
409+
<enum>FALSE=0, TRUE=1</enum>
410+
<writeable/>
411+
<initToZero/>
412+
</attribute>
413+
<!-- ********************************************************************* -->
414+
<attribute>
415+
<id>ATTR_WOF_ENABLED</id>
416+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
417+
<description>Indicator that all relevent attributes and required data for
418+
WOF to be enabled is present and valid
419+
420+
Producer: p9_build_pstate_datablock
421+
422+
Consumers: p9_hcode_image_build ->
423+
PGPE Header
424+
CME Header
425+
</description>
426+
<valueType>uint8</valueType>
427+
<enum>FALSE=0, TRUE=1</enum>
428+
<writeable/>
429+
<initToZero/>
430+
</attribute>
431+
<!-- ********************************************************************* -->
330432
</attributes>

0 commit comments

Comments
 (0)