Skip to content

Commit

Permalink
L3 update -- p9_fbc_eff_config_links
Browse files Browse the repository at this point in the history 
  update comments, error descriptions, add callouts

Change-Id: I9da5dcde8f35e4902e06c88b039989b58dba7cd8
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40271
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: DHRUVARAJ SUBHASH CHANDRAN <dhruvaraj@in.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40275
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
@jjmcgill @dcrowell77
jjmcgill authored and dcrowell77 committed May 23, 2017
1 parent bbf080c commit 4a61930
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 10 deletions.
10 changes: 5 additions & 5 deletions src/import/chips/p9/procedures/hwp/nest/p9_fbc_eff_config_links.C
View file
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2016 */
/* Contributors Listed Below - COPYRIGHT 2016,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand All @@ -29,7 +29,7 @@
/// *HWP HWP Owner: Joe McGill <jmcgill@us.ibm.com>
/// *HWP FW Owner: Thi Tran <thi@us.ibm.com>
/// *HWP Team: Nest
/// *HWP Level: 2
/// *HWP Level: 3
/// *HWP Consumed by: HB,FSP
///

Expand Down Expand Up @@ -227,7 +227,7 @@ fapi2::ReturnCode p9_fbc_eff_config_links_query_endp(
.set_REM_TARGET(l_rem_target)
.set_LOC_FBC_GROUP_ID(i_loc_fbc_group_id)
.set_REM_FBC_GROUP_ID(l_rem_fbc_group_id),
"X connected chips do not have the same group ID");
"Local and remote endpoints expected to lie in the same group have different group IDs");
o_rem_fbc_id[l_loc_link_id] = l_rem_fbc_chip_id;
}
else
Expand All @@ -239,7 +239,7 @@ fapi2::ReturnCode p9_fbc_eff_config_links_query_endp(
.set_REM_TARGET(l_rem_target)
.set_LOC_FBC_CHIP_ID(i_loc_fbc_chip_id)
.set_REM_FBC_CHIP_ID(l_rem_fbc_chip_id),
"A connected chips do not have the same chip ID");
"Local and remote endpoints expected to lie in different groups have different chip IDs");
o_rem_fbc_id[l_loc_link_id] = l_rem_fbc_group_id;
}
}
Expand Down Expand Up @@ -397,7 +397,7 @@ p9_fbc_eff_config_links(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_tar
FAPI_TRY(FAPI_ATTR_SET(fapi2::ATTR_PROC_FABRIC_A_ATTACHED_CHIP_ID, i_target, l_a_rem_fbc_group_id),
"Error from FAPI_ATTR_SET (ATTR_PROC_FABRIC_A_ATTACHED_CHIP_ID)");

// initialize all link realted attributes?
// initialize all aggregate link related attributes?
if (i_op == SMP_ACTIVATE_PHASE1)
{
// aggregate (local+remote) delays
Expand Down
4 changes: 2 additions & 2 deletions src/import/chips/p9/procedures/hwp/nest/p9_fbc_eff_config_links.H
View file
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2016 */
/* Contributors Listed Below - COPYRIGHT 2016,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand All @@ -31,7 +31,7 @@
/// *HWP HWP Owner: Joe McGill <jmcgill@us.ibm.com>
/// *HWP FW Owner: Thi Tran <thi@us.ibm.com>
/// *HWP Team: Nest
/// *HWP Level: 2
/// *HWP Level: 3
/// *HWP Consumed by: HB,FSP
///

Expand Down
20 changes: 17 additions & 3 deletions src/import/chips/p9/procedures/xml/error_info/p9_fbc_eff_config_links_errors.xml
View file
Expand Up @@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER HostBoot Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2016 -->
<!-- Contributors Listed Below - COPYRIGHT 2016,2017 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
Expand All @@ -29,24 +29,34 @@
<rc>RC_P9_FBC_EFF_CONFIG_LINKS_CHIP_ID_ERR</rc>
<description>
Procedure: p9_fbc_eff_config_links
Two A connected chips do not have the same chip ID
Two chips expected to lie in different FBC groups (X connected with
CHIP_IS_GROUP, OR A connected) do not have the same FBC chip ID
</description>
<ffdc>LOC_TARGET</ffdc>
<ffdc>REM_TARGET</ffdc>
<ffdc>LOC_FBC_CHIP_ID</ffdc>
<ffdc>REM_FBC_CHIP_ID</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>HIGH</priority>
</callout>
</hwpError>
<!-- ******************************************************************** -->
<hwpError>
<rc>RC_P9_FBC_EFF_CONFIG_LINKS_GROUP_ID_ERR</rc>
<description>
Procedure: p9_fbc_eff_config_links
Two X connected chips do not have the same group ID
Two chips expected to lie in the same FBC group (X connected with
CHIP_IS_NODE) do not have the same FBC group ID
</description>
<ffdc>LOC_TARGET</ffdc>
<ffdc>REM_TARGET</ffdc>
<ffdc>LOC_FBC_GROUP_ID</ffdc>
<ffdc>REM_FBC_GROUP_ID</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>HIGH</priority>
</callout>
</hwpError>
<!-- ******************************************************************** -->
<hwpError>
Expand All @@ -57,6 +67,10 @@
</description>
<ffdc>TARGET</ffdc>
<ffdc>UNIT_ID</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>HIGH</priority>
</callout>
</hwpError>
<!-- ******************************************************************** -->
</hwpErrors>

0 comments on commit 4a61930

Please sign in to comment.