Skip to content

Commit 50b92ed

Browse files
Shelton Leungdcrowell77
authored andcommitted
disable noise window for DD1 HW406577
Change-Id: Iff2cdae61e72f9ebdc020a730bc3d8ffd5b23118 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38313 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Jenny Huynh <jhuynh@us.ibm.com> Reviewed-by: LUKE MURRAY <murrayl@us.ibm.com> Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38320 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
1 parent 12e724b commit 50b92ed

File tree

3 files changed

+33
-3
lines changed

3 files changed

+33
-3
lines changed

src/import/chips/p9/initfiles/p9.mca.scom.initfile

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@
3434
#-- REFERENCES FOR FILE
3535
#--******************************************************************************
3636
# Files used to check what target type attributes are
37-
# /afs/awd/projects/eclipz/pz6/usr/sleung/ekb/chips/p9/procedures/xml/attribute_info/memory_mcs_attributes.xml
38-
# /afs/awd/projects/eclipz/pz6/usr/sleung/ekb/chips/p9/procedures/xml/attribute_info/memory_spd_attributes.xml
39-
# /afs/awd/projects/eclipz/pz6/usr/sleung/ekb/chips/p9/procedures/xml/attribute_info/memory_mr_attributes.xml
37+
# /afs/awd/projects/eclipz/pz6/usr/sleung/ekb2/ekb/chips/p9/procedures/xml/attribute_info/memory_mcs_attributes.xml
38+
# /afs/awd/projects/eclipz/pz6/usr/sleung/ekb2/ekb/chips/p9/procedures/xml/attribute_info/memory_spd_attributes.xml
39+
# /afs/awd/projects/eclipz/pz6/usr/sleung/ekb2/ekb/chips/p9/procedures/xml/attribute_info/memory_mr_attributes.xml
4040
# Example:
4141
# <id>ATTR_EFF_NUM_RANKS_PER_DIMM</id>
4242
# <targetType>TARGET_TYPE_MCS</targetType>
@@ -754,3 +754,9 @@ ispy MC01.PORT0.ATCL.CL.CLSCOM.MCAMOC_WRTO_AMO_COLLISION_RULES [when=S && ATTR_C
754754
spyv;
755755
0b0000000000000000000000000;
756756
}
757+
758+
# Noise Window DIsable (HW406577)
759+
ispy MCP.PORT0.ECC64.SCOM.MBSECCQ_ENABLE_UE_NOISE_WINDOW [when=S && ATTR_CHIP_EC_FEATURE_HW406577] {
760+
spyv;
761+
0b0;
762+
}

src/import/chips/p9/procedures/hwp/initfiles/p9_mca_scom.C

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ constexpr uint64_t literal_14 = 14;
6868
constexpr uint64_t literal_597 = 597;
6969
constexpr uint64_t literal_768 = 768;
7070
constexpr uint64_t literal_939 = 939;
71+
constexpr uint64_t literal_0b0 = 0b0;
7172

7273
fapi2::ReturnCode p9_mca_scom(const fapi2::Target<fapi2::TARGET_TYPE_MCA>& TGT0,
7374
const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>& TGT1, const fapi2::Target<fapi2::TARGET_TYPE_MCS>& TGT2,
@@ -681,6 +682,12 @@ fapi2::ReturnCode p9_mca_scom(const fapi2::Target<fapi2::TARGET_TYPE_MCA>& TGT0,
681682
l_scom_buffer.insert<46, 11, 53, uint64_t>(l_def_REFRESH_INTERVAL );
682683
FAPI_TRY(fapi2::putScom(TGT0, 0x7010935ull, l_scom_buffer));
683684
}
685+
{
686+
FAPI_TRY(fapi2::getScom( TGT0, 0x7010a0aull, l_scom_buffer ));
687+
688+
l_scom_buffer.insert<26, 1, 63, uint64_t>(literal_0b0 );
689+
FAPI_TRY(fapi2::putScom(TGT0, 0x7010a0aull, l_scom_buffer));
690+
}
684691

685692
};
686693
fapi_try_exit:

src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2528,6 +2528,23 @@
25282528
</chipEcFeature>
25292529
</attribute>
25302530

2531+
<attribute>
2532+
<id>ATTR_CHIP_EC_FEATURE_HW406577</id>
2533+
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
2534+
<description>
2535+
Noise window disabled in DD1 because continually reocurring intermittent UE's can cause us to hang on refreshes.
2536+
</description>
2537+
<chipEcFeature>
2538+
<chip>
2539+
<name>ENUM_ATTR_NAME_NIMBUS</name>
2540+
<ec>
2541+
<value>0x20</value>
2542+
<test>LESS_THAN</test>
2543+
</ec>
2544+
</chip>
2545+
</chipEcFeature>
2546+
</attribute>
2547+
25312548
<attribute>
25322549
<id>ATTR_CHIP_EC_FEATURE_MSS_CHECK_DISABLE_HW_VREF_CAL</id>
25332550
<targetType>TARGET_TYPE_PROC_CHIP</targetType>

0 commit comments

Comments
 (0)